Tests, docstrings, and deprecation for utils.py #134
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
6 tasks
rknop
reviewed
Aug 14, 2025
| } | ||
|
|
||
| # @pytest.fixture( scope='session' ) | ||
| # def test_truth_file(): |
There was a problem hiding this comment.
I know this is commented out, but : I'm always afraid to name pytest fixtures anything starting with test_, because the way pytest works is it looks through all of the files in directories you tell it to run and looks for functions whose names start with test. (It may only look through files whose names themselves start with test; one of the things I really don't like about pytest is that it's behavior depends so much on the details of how you name stuff. I thought we got rid of that shit when we got rid of Fortran-77.)
There was a problem hiding this comment.
I named it this because the fixture above it is called "test_dia_image"--should I rename that, as well?
rknop
approved these changes
Aug 14, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Aug 14, 2025
Tests, docstrings, and deprecation for utils.py 9c64133
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.