Skip to content

Fix a bug that passed the wrong thign to stampmaker, so stampmaker was always failing #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 8, 2025
Merged

Fix a bug that passed the wrong thign to stampmaker, so stampmaker was always failing #147

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
814788b
Fix a bug that passed the wrong thign to stampmaker, so stampmaker wa…
rknop Sep 8, 2025
f9d6453
changelog
rknop Sep 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changes/147.bugfix.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix a bug that passed the wrong thing to stampmaker, so stampmaker was always failing
8 changes: 4 additions & 4 deletions phrosty/pipeline.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -798,12 +798,12 @@ def log_stamp_err( x ):

partialstamp = partial(stampmaker, self.diaobj.ra, self.diaobj.dec, np.array([100, 100]))
# template path, savedir, savename
templstamp_args = ( (ti.image.path, self.dia_out_dir, f'stamp_{str(ti.image.name)}')
for ti in self.template_images )

templstamp_args = ( (ti.image, self.dia_out_dir, f'stamp_{str(ti.image.name)}')
for ti in self.template_images )
if self.nwrite > 1:
with Pool( self.nwrite ) as templ_stamp_pool:
templ_stamp_pool.starmap_async( partialstamp, templstamp_args )
templ_stamp_pool.starmap_async( partialstamp, templstamp_args,
error_callback=log_stamp_err )
templ_stamp_pool.close()
templ_stamp_pool.join()

Expand Down