Switch to fitsio to write FITS faster. #149
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rknop
approved these changes
Sep 12, 2025
There was a problem hiding this comment.
This looks fine for what it it is. I predict it doesn't make much performance difference.
What we really need to do is look at the FITS classes in snappl. I think phrosty uses those enough to write temporary and diagnostic output files that it would make a bigger difference.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch from
astropy.io.fitstofitsio.Closed #148
Very minor code change.
Running a lightcurve with 77 science files against 1 template file is more than 2x as fast in wall clock (18 minutes instead of 40 minutes) and more than 4x as fast in total CPU time (25 min instead of 116). This is running with 3 parallel writers.
@rknop I know you asked for this to go into
snappl, but It would be a bit more work to redo how PSF objects are calculated and stored to make this something that could go intosnappl. Totally doable, but doing the fitsio change here inphrostywas 6 lines.