free memory. update phrosty_config.yaml to match #95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
wmwv
approved these changes
Jul 7, 2025
There was a problem hiding this comment.
LGTM
Editorializing: I think this memory tracing and freeing would be largely unnecessary if the subtraction processing was separated out into a function that loaded an image and ran just one subtraction. That would make it easy for Python to figure out it didn't need the memory anymore after the function returned. Having this for loop that runs all of this stuff and then explicitly calling self.image.free() is kind of trying to recreate what you would get naturally if this big block were just its own function.
github-actions bot
pushed a commit
that referenced
this pull request
Jul 8, 2025
free memory. update phrosty_config.yaml to match 4d537c2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.