-
-
Notifications
You must be signed in to change notification settings - Fork 87
Prepare a Runestone CodeTailor version optimized for production (initial attempt) #966
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Prepare a Runestone CodeTailor version optimized for production (initial attempt) #966
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, the good news.
- It does not appear as though your changes break anything about current activecode or parsons problems
However I can't test any further.
- Please structure your changes to the overview book like a chapter so that it appears in the table of contents.
- the book server crashes when I finally figured out how to navigate my wat to the samples. It is missing the
openai
and I'm guessingjavlang
modules - You should be able to fully test this in a working docker environment. When you have done that please submit your updates.
The documentation for build and running and rebuilding containers is all on https://runestone-monorepo.readthedocs.io/en/latest/
@@ -126,6 +126,9 @@ runestone = { path = "./projects/interactives", develop = true } | |||
rsmanage = { path = "./projects/rsmanage", develop = true } | |||
json2xml = "^3.21.0" | |||
pytest-asyncio = "^0.24.0" | |||
openai = "^1.59.3" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is good to have these here, but they also need to be added to the pyproject.toml file in the book project.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, are those the two places to add the new packages? Or is there more places I need to include these two new packages?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any of the servers that need those libraries need to be updated. I think it is just the book server that you are using to interface to openai.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also noticed that when it crashed the book server the web page spinner just kept spinning and giving me encouraging messages. You should detect a failure and give an appropriate message to the user.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I only require them in the book server. I am adding it to the pyproject.toml there
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, I will change it to an error message to the user. I am setting it as either resolve when the backend responds, or reject and send an error message if it takes longer than 1 minute.
Add a comment to keep @barbarer in the loop. |
This PR introduces a Runestone-specific CodeTailor version (codetailor-runestone-ver) based on the latest upstream main branch.
Note:
pyproject.toml
Runestone-specific version:
book_server_api
coach.py
fetch_api_token
(real service).personalize_parsons
activecode
componentparsons
component:scaffolding:
to separate scaffolding puzzle code