Reorganize symphonia's feature flags #733
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Symphonia's feature flags are separated into format flags and codec flags.
Current symphonia flags wrapped in rodio is a mixture of these two types.
This PR reorganize these flags to format-based (extension-based like).
The flags are separated by format and each flags are contains possible codec flags in the format.
Detail
symphonia-aac
not changed
symphonia-flac
not changed
symphonia-isomp4
mpa(mp3+mp2+mp1), aac, alac flags are added.
symphonia-mp3
not changed
symphonia-ogg
vorbis, flac, pcm flags are added
symphonia-vorbis
deleted
vorbis flag is codec name in symphonia
Standalone vorbis format is not general as far as I could find.
symphonia-wav
not changed
symphonia-alac
not changed
symphonia-aiff
not changed
symphonia-caf
added
Core Audio Format support
With pcm, adpcm, mpa(mp3+mp2+mp1), aac, alac flags
symphonia-mkv
added
mkv (actually mka) and webm support
With aac, mpa, vorbis, pcm, flac, alac flags
Note:
Currently, symphonia is not support opus codec.
These formats can contain opus format.
isomp4, ogg, caf, mkv(webm)