Skip to content

Reorganize symphonia's feature flags #733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Keinsleif
Copy link
Contributor

@Keinsleif Keinsleif commented Apr 16, 2025

Symphonia's feature flags are separated into format flags and codec flags.
Current symphonia flags wrapped in rodio is a mixture of these two types.

This PR reorganize these flags to format-based (extension-based like).
The flags are separated by format and each flags are contains possible codec flags in the format.

Detail

  • symphonia-aac
    not changed

  • symphonia-flac
    not changed

  • symphonia-isomp4
    mpa(mp3+mp2+mp1), aac, alac flags are added.

  • symphonia-mp3
    not changed

  • symphonia-ogg
    vorbis, flac, pcm flags are added

  • symphonia-vorbis
    deleted
    vorbis flag is codec name in symphonia
    Standalone vorbis format is not general as far as I could find.

  • symphonia-wav
    not changed

  • symphonia-alac
    not changed

  • symphonia-aiff
    not changed

  • symphonia-caf
    added
    Core Audio Format support
    With pcm, adpcm, mpa(mp3+mp2+mp1), aac, alac flags

  • symphonia-mkv
    added
    mkv (actually mka) and webm support
    With aac, mpa, vorbis, pcm, flac, alac flags

Note:
Currently, symphonia is not support opus codec.
These formats can contain opus format.
isomp4, ogg, caf, mkv(webm)

@dvdsk
Copy link
Collaborator

dvdsk commented Apr 16, 2025

First off all thanks for helping out!

D note some of this work is underway in PR731. I do however not think @roderickvd minds you taking this on instead.

Please see the related discussion in: #731

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants