-
Notifications
You must be signed in to change notification settings - Fork 279
chore(ui5-toolbar-select): value and label added #11972
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
PetyaMarkovaBogdanova
wants to merge
14
commits into
main
Choose a base branch
from
add-toolbar-select-apis
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+104
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nents into add-toolbar-select-apis
…nents into add-toolbar-select-apis
…nents into add-toolbar-select-apis
dobrinyonkov
reviewed
Aug 5, 2025
Looking good, just a few stuff: 1) changing the selected option isn't updating the value property of the ui5-toolbar-select
we may need to create a getter that returns the value property from the internal select /**
* Defines the value of the component:
*
* @public
* @default ""
* @since 2.13.0
*/
@property()
set value(newValue: string) {
if (this.select) {
this.select.value = newValue;
}
}
get value() {
return this.select ? this.select.value : "";
}
get select(): Select | null {
return this.shadowRoot!.querySelector<Select>("[ui5-select]");
} 2) let's also create a new snippet in the ToolbarSelect.html 3) looks like we don't yet need individualSlots on the options slot |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: 11706
This pull request introduces enhancements to the
ToolbarSelect
component, focusing on improved functionality for handling custom labels and values. Below is a summary of the most important changes:Enhancements to
ToolbarSelect
Functionality:label
slot to allow custom HTML elements to be displayed as part of the component's input section. This enables dynamic customization of the label displayed alongside the select dropdown.value
property to correspond to the ui5-select 'value' prop. It is passed to theSelect
element in the wrapper component's template.