fix(framework): sap-ui-themeRoot block all origins by defaultTheme root disallow default #12035
+46
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nnaydenow
approved these changes
Aug 5, 2025
ilhan007
pushed a commit
that referenced
this pull request
Aug 6, 2025
…ot disallow default (#12035)
|
🎉 This PR is included in version v2.14.0-rc.0 🎉 The release is available on v2.14.0-rc.0 Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change addresses 2 bugs:
validateThemeRootnot called forsap-ui-themeRoot=URLbut rather just for the newersap-ui-theme=sap_horizon@URLformatAdditionally:
sap-allowed-theme-originsis now the preferred name of the<metatagIMPORTANT: If you were relying on the old default behavior (setting no
<metatag allows all origins), you should explicitly add:to achieve the same results. However, we strongly advice against doing so. The best practice is to only list the trusted domains and use
*as a last resort, if absolutely necessary.