Skip to content

fix: remove duplicate logbook endpoint calls #1983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
+8 −0
Open

fix: remove duplicate logbook endpoint calls #1983

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
34843ef
removed duplicate logbook endpoint calls
abdimo101 Aug 27, 2025
4e5a45f
changed which call to trigger and kept the fetchCountAction, so now 2…
abdimo101 Aug 27, 2025
dede70f
WIP: fixing some e2e tests
abdimo101 Aug 27, 2025
8b4d333
Merge branch 'master' into removing-duplicate-logbook-calls
abdimo101 Aug 27, 2025
3337c26
WIP: reverting all changes to check e2e tests in pipeline
abdimo101 Aug 27, 2025
47eb134
Merge branch 'removing-duplicate-logbook-calls' of github.com:SciCatP…
abdimo101 Aug 27, 2025
bc7795e
removing duplicated api calls
abdimo101 Aug 28, 2025
5a417a0
created a new case
abdimo101 Aug 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/app/datasets/dataset-details-dashboard/dataset-details-dashboard.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,6 +249,14 @@ export class DatasetDetailsDashboardComponent
}
}
break;
case TAB.logbook:
{
const { loaded } = this.fetchDataActions[TAB.logbook];
if (!loaded) {
this.fetchDataActions[TAB.logbook].loaded = true;
}
}
break;
default: {
const { action, loaded } = this.fetchDataActions[tab];
if (!loaded) {
Expand Down
Loading