Make a clearer link to site source code #473
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| <div> | ||
| <p>All website code is licensed {{ site.custom.license.site_code }}. Unless otherwise specified, all website content is licensed {{ site.custom.license.content }}.</p> | ||
| <p>All <a href="https://github.com/SeaGL/seagl.github.io">website code</a> is licensed {{ site.custom.license.site_code }}. Unless otherwise specified, all website content is licensed {{ site.custom.license.content }}.</p> |
There was a problem hiding this comment.
This location is a little awkward since the context is establishing a dichotomy between code and content. Maybe something like this?
This website is open source. Unless otherwise specified, its code is licensed GPL v3.0 and its content is licensed CC BY-SA.
I do also like the per-page links e.g. “Edit” on session archives, though those probably should say “Source” instead.
There was a problem hiding this comment.
Actually, I meant to file an issue about per-page "Edit this page" links and forgot, and filed this instead. (I didn't realize the session archives had these already.)
Maybe we should close this PR in favor of that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you're just looking for a link to the site source code, it isn't super clear that the GPL link would link you there until you actually look at the link target, and even then it's annoying that it links you to the license file when you just wanted the repo root.
I considered putting something in
_config.ymlto match the rest of the file... but it seems like unnecessary indirection? And, it seems kind of awkward that the text that's in this link would be in the config file, which effectively couples these files. But then just putting in the URL felt kind of weird and inconsistent too.