Skip to content

More HotWired improvements & Websockets #1454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 36 commits into
base: master
Choose a base branch
from
Open

More HotWired improvements & Websockets #1454

wants to merge 36 commits into from

Conversation

jbrichau
Copy link
Member

No description provided.

Johan Brichau added 14 commits August 16, 2022 15:52
initial work on Seaside-WebSocket, inspired by Seaside-Comet
dd73c34
added websocket packages to the baseline
a8dc18e
fix websockets in baseline
c2aa27a
Move class ZnSeasideWebSocketDelegate to Seaside-WebSocket-Zinc package
701487a
Created a dedicated request handler for websocket setup + some change…
c5ebab2 
…s to better package Zinc's Websocket code
pushing javascript for execution moved to separate subclass of websoc…
0217078 
…ket "pusher" + cleaned up javascript generation and execution client-side
Some improvements to the code as per PR feedback
1611ec2
Added the slider example using websockets
6307cfc
send/receive over websocket touches session preventing expiry
64c3a5b
Merge branch 'master' into websockets
9efdaf3
Merge branch 'master' into websockets
e34adad 
# Conflicts:
#	repository/BaselineOfSeaside3.package/BaselineOfSeaside3.class/instance/baselineadaptors..st
#	repository/Seaside-Zinc-Core.package/ZnZincServerAdaptor.class/instance/websocketResponseFrom..st
Correct baseline for websockets
f305106
just some code style corrections
944f3e1
Expanded basic tests for Hotwired and added turboShow: onAnswer:
abe043f
@codecov Codecov
Copy link

codecov bot commented Feb 24, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0.64516% with 2926 lines in your changes missing coverage. Please review.

Project coverage is 51.80%. Comparing base (7058248) to head (20cb5cc).

Files with missing lines Patch % Lines
...WAStimulusFileLibrary.class/instance/stimulusJs.st 0.00% 2566 Missing ⚠️
...oFileLibrary.class/instance/turboes2017esmminJs.st 0.00% 37 Missing ⚠️
...erTestComponent.class/instance/renderContentOn..st 0.00% 17 Missing ⚠️
...usTestsLibrary.class/instance/helloControllerJs.st 0.00% 16 Missing ⚠️
...sFunctionalTest.class/instance/renderContentOn..st 0.00% 15 Missing ⚠️
...ge/WATurboFrame.class/instance/renderContentOn..st 0.00% 12 Missing ⚠️
...sFunctionalTest.class/instance/renderContentOn..st 0.00% 12 Missing ⚠️
...aElement.extension/instance/turboRefreshMethod..st 0.00% 11 Missing ⚠️
...s/instance/turboStreamAction.target.morph.with..st 0.00% 11 Missing ⚠️
...aElement.extension/instance/turboRefreshScroll..st 0.00% 9 Missing ⚠️
... and 52 more
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1454      +/-   ##
==========================================
+ Coverage   49.41%   51.80%   +2.38%     
==========================================
  Files        9118     9163      +45     
  Lines       80389    76720    -3669     
==========================================
+ Hits        39726    39742      +16     
+ Misses      40663    36978    -3685

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jbrichau jbrichau marked this pull request as ready for review June 19, 2025 12:48
@jbrichau jbrichau changed the title More HotWired improvements More HotWired improvements & Websockets Jun 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jbrichau