Skip to content

assignment one finished #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

kazshah23
Copy link

No description provided.

@ApoorvaAditya
Copy link
Contributor

Hey Kazmain, Your code looks pretty good! The only thing that I would comment on is that using if and else cases inside of the build function sometimes leads to having less readable code, so it is usually preferred to make small helper functions to handle the logic, but for this simple assignment this is alright. Good job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants