Skip to content

[skiplang/prelude] Get rid of stale debug_break(). #952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[skiplang/prelude] Get rid of stale debug_break(). #952

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a2cd2e2
[skiplang/prelude] Get rid of stale `debug_break()`.
beauby Jun 13, 2025
edabb65
Merge branch 'main' into debug-break
beauby Jun 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions skiplang/prelude/preamble/preamble32.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,6 @@ declare i32 @__gxx_personality_v0(...)
declare ptr @__cxa_begin_catch(ptr)
declare void @__cxa_end_catch()

; Function Attrs: alwaysinline nounwind uwtable
define void @SKIP_debug_break() {
ret void
}

; Obstack

declare ptr @SKIP_Obstack_alloc(i32)
Expand Down
8 changes: 0 additions & 8 deletions skiplang/prelude/preamble/preamble64.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,14 +22,6 @@ declare i32 @__gxx_personality_v0(...)
declare ptr @__cxa_begin_catch(ptr)
declare void @__cxa_end_catch()

declare void @llvm.debugtrap() nounwind

; Function Attrs: alwaysinline nounwind uwtable
define void @SKIP_debug_break() {
tail call void @llvm.debugtrap()
ret void
}

; Awaitable

define void @SKIP_awaitableNotifyWaitersValueIsReady(ptr) {
Expand Down
5 changes: 0 additions & 5 deletions skiplang/prelude/src/stdlib/other/System.sk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,6 @@
// This performs a deep, O(n), copy
// native fun freeze<T>(T): frozen T;

// Break into the debugger if one is attached.
@debug
@cpp_runtime
native fun debug_break(): void;

// Recursively interns ("hash-conses", "uniquifies") the given object,
// uses the Skip memoizer's interner to provide the canonical copy of any
// frozen object, where equality is defined in the deep structural bitwise
Expand Down