add expr length tests #8052
add expr length tests #8052
Conversation
F1r3w477
requested review from
cheeezburga and
Burbulinis
and removed request for
a team
skriptlang-automation
bot
added
the
needs reviews
skriptlang-automation
bot
removed
the
needs reviews
I think substring and joining should be tested elsewhere. ie: In |
Efnilite
added
the
enhancement
skriptlang-automation
bot
added
the
feature-ready
| assert length of " " is 3 with "Length of a string with only whitespace should be correct" | ||
| assert length of "😂" is 2 with "Length of a Unicode emoji should be calculated correctly" | ||
|
|
||
| test "type conversion for length": |
There was a problem hiding this comment.
I don't think this test is necessary - it's not handled by ExprLength but rather internally (and should be tested elsewhere)
There was a problem hiding this comment.
Good point about the test for the undefined variable. I'll remove that assertion.
Regarding the length of "12345" test, my intention was to test the expression with a string literal that contains numeric characters. Since ExprLength is registered for %strings%, this directly tests its intended functionality.
To avoid future confusion, I'll renamed the test block from "type conversion for length" to "numeric string length"
| assert {_lengths::2} is 2 with "Second element of looped lengths should be correct" | ||
| assert {_lengths::3} is 6 with "Third element of looped lengths should be correct" | ||
|
|
||
| test "string interpolation": |
There was a problem hiding this comment.
I think this is also not really necessary and should be handled in a different test focused on VariableString behavior
There was a problem hiding this comment.
I agree that this test would ideally live in a dedicated VariableString.sk file.
Given that overall test coverage is a known issue Skript is working to improve, would it be acceptable to keep this integration test here for now? This ensures this case is covered now, rather than waiting until a VariableString.sk file is created.
It can always be moved to a more appropriate file later on.
Problem
The Skript project currently has very low test coverage for its existing syntax, making it difficult to ensure changes don't introduce regressions. Specifically, the core length of expression was untested.
Solution
This PR adds a new syntax test file,
ExprLength.sk, to provide unit test coverage for the length of expressions.The tests cover behavior for:
String literals and variables.
Edge cases like empty strings, whitespace, and Unicode characters.
Automatic type conversion from numbers.
The list-looping behavior when applied to a list of strings.
String interpolation.
Testing Completed
Added the
ExprLength.sktest. The full test suite was run via .\gradlew skriptTest and passed successfully.Supporting Information
None
Completes: none
Related: #6158