Skip to content

Feature/players listed #8101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 13 commits into
base: dev/feature
Choose a base branch
from
Open

Feature/players listed #8101

wants to merge 13 commits into from

Conversation

TheLimeGlass
Copy link
Contributor

Problem

Skript can't get the tablisted players, and paper has api for it.

Solution

added, a new expression using the isListed api.

Testing Completed

tested syntax, it wok

Completes: none
Related: none

@TheLimeGlass TheLimeGlass requested a review from a team as a code owner August 1, 2025 05:01
@TheLimeGlass TheLimeGlass requested review from Efnilite and cheeezburga and removed request for a team August 1, 2025 05:01
@skriptlang-automation skriptlang-automation bot added the needs reviews A PR that needs additional reviews label Aug 1, 2025
sovdeeth
sovdeeth requested changes Aug 1, 2025
View reviewed changes
Copy link
Member

@sovdeeth sovdeeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm rather disappointed in the lack of effort in the PR description, but thank you for at least filling it out. Please be sure to put some effort into the description in any future PRs you make.

@TheLimeGlass TheLimeGlass requested a review from sovdeeth August 1, 2025 09:29
@TheLimeGlass
Copy link
Contributor Author

TheLimeGlass commented Aug 1, 2025 •
edited
Loading

I'm rather disappointed in the lack of effort in the PR description, but thank you for at least filling it out. Please be sure to put some effort into the description in any future PRs you make.

That is not how you should be talking to contributors, Especially core developers.

Burbulinis
Burbulinis requested changes Aug 1, 2025
View reviewed changes
@skriptlang-automation skriptlang-automation bot added needs reviews A PR that needs additional reviews and removed needs reviews A PR that needs additional reviews labels Aug 1, 2025
@TheLimeGlass TheLimeGlass requested a review from Burbulinis August 1, 2025 11:20
sovdeeth
sovdeeth approved these changes Aug 1, 2025
View reviewed changes
@sovdeeth sovdeeth added the feature Pull request adding a new feature. label Aug 1, 2025
@skriptlang-automation skriptlang-automation bot added feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. and removed needs reviews A PR that needs additional reviews labels Aug 1, 2025
Efnilite
Efnilite requested changes Aug 2, 2025
View reviewed changes
@skriptlang-automation skriptlang-automation bot removed the feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. label Aug 2, 2025
@TheLimeGlass TheLimeGlass requested a review from Efnilite August 4, 2025 12:34
@skriptlang-automation skriptlang-automation bot added the feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. label Aug 4, 2025
@Absolutionism Absolutionism moved this to Awaiting Merge in 2.13 Releases Aug 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sovdeeth sovdeeth sovdeeth approved these changes

@Efnilite Efnilite Efnilite approved these changes

@Absolutionism Absolutionism Absolutionism approved these changes

@Burbulinis Burbulinis Burbulinis approved these changes

@cheeezburga cheeezburga Awaiting requested review from cheeezburga cheeezburga is a code owner automatically assigned from SkriptLang/core-developers

Assignees
No one assigned
Labels
feature Pull request adding a new feature. feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version.
Projects
2.13 Releases
Status: Awaiting Merge
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@TheLimeGlass @sovdeeth @Efnilite @Absolutionism @Burbulinis