selection: instantly notify clients when source dies #1762
+327
−115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YaLTeR
reviewed
Jun 21, 2025
kchibisov
force-pushed
the
smithay-drop-selection
branch
from
32e34dc to
ea39757
Compare
kchibisov
force-pushed
the
smithay-drop-selection
branch
from
ea39757 to
3377ed3
Compare
Smithay uses lazy notify when there's actual interaction, which is unexpected and doesn't properly reflect the state of the clipboard to clipboard managers. Instead immediately notify clients when the source was destroyed by sending `null`. Links: YaLTeR/niri#1831
kchibisov
force-pushed
the
smithay-drop-selection
branch
from
3377ed3 to
c521b10
Compare
YaLTeR
approved these changes
Jun 21, 2025
|
CI failure is unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Smithay uses lazy notify when there's actual interaction, which is unexpected and doesn't properly reflect the state of the clipboard. Instead immediately notify clients when the source was destroyed.
Links: YaLTeR/niri#1831
--
Need to do that for all the rest of the selections protocols and drop the
alivecheck, I guess.