[In Progress] Bump + Release KFP + Docker #141
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Shubham Vij <[email protected]>
Co-authored-by: Shubham Vij <[email protected]>
Co-authored-by: Shubham Vij <[email protected]>
Co-authored-by: Shubham Vij <[email protected]>
Co-authored-by: Shubham Vij <[email protected]>
svij-sc
commented
Jul 14, 2025
| @@ -0,0 +1,224 @@ | |||
| """ | |||
There was a problem hiding this comment.
Renaming and slighlty modifying scripts/bump_version.py script.
svij-sc
commented
Jul 14, 2025
| GIGL_SRC_IMAGE_CUDA = "TODO - make this public" | ||
| GIGL_SRC_IMAGE_CPU = "TODO - make this public" | ||
| GIGL_DATAFLOW_IMAGE = "TODO - make this public" | ||
|
|
There was a problem hiding this comment.
migrated to python/gigl/common/constants.py
svij-sc
commented
Jul 14, 2025
| push: | ||
| # branches: | ||
| # - main | ||
| # - 'release/*' |
There was a problem hiding this comment.
TODO: remove on-push.
We can reserve this workflow to only be executed from workflow_dispatch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope of work done
Where is the documentation for this feature?: N/A
Did you add automated tests or write a test plan?
Updated Changelog.md? NO
Ready for code review?: NO