Skip to content

Conversation

svij-sc
Copy link
Collaborator

@svij-sc svij-sc commented Aug 22, 2025

Scope of work done

This PR was originally gong to be just a follow up from: https://github.com/Snapchat/GiGL/pull/279/files#r2289567700
But, noticed that w/ the new version of pip-tools it is not able to compile MAC requirements anymore as it was before.

  • Locked pip-tools version
  • Update reqs

Where is the documentation for this feature?: N/A

Did you add automated tests or write a test plan?

Updated Changelog.md? NO

Ready for code review?: NO

Co-authored-by: Shubham Vij <[email protected]>
@Snapchat Snapchat deleted a comment from github-actions bot Aug 22, 2025
@Snapchat Snapchat deleted a comment from github-actions bot Aug 29, 2025
@Snapchat Snapchat deleted a comment from github-actions bot Aug 29, 2025
@Snapchat Snapchat deleted a comment from github-actions bot Aug 29, 2025
Copy link
Contributor

GiGL Automation

@ 20:05:41UTC : Starting to generate hashed requirements from pyproject.toml.
This may take a while, please be patient.
Once done, the workflow will update the relevant requirements/*.txt files.

@Snapchat Snapchat deleted a comment from github-actions bot Aug 29, 2025
@Snapchat Snapchat deleted a comment from github-actions bot Aug 29, 2025
Copy link
Contributor

GiGL Automation

@ 20:08:39UTC : Built and pushed updated requirements files.

Co-authored-by: Shubham Vij <[email protected]>
Copy link
Contributor

GiGL Automation

@ 20:12:51UTC : Starting to build base images for CUDA and CPU.
This may take a while, please be patient.
The images will be pushed to the GCP Artifact Registry.
Once done, the workflow will update the dep_vars.env file with the new image names.

@svij-sc svij-sc changed the title Change to revert Lock pip-compile version + follow up (#279 ) regen reqs / images Aug 29, 2025
Copy link
Contributor

GiGL Automation

@ 20:33:00UTC : Built and pushed new images:

  • CUDA base image: us-central1-docker.pkg.dev/external-snap-ci-github-gigl/public-gigl/gigl-cuda-base:ea5cafee34c508ea98b3e5a7cf69e4e226cd0247.37.1
  • CPU base image: us-central1-docker.pkg.dev/external-snap-ci-github-gigl/public-gigl/gigl-cpu-base:ea5cafee34c508ea98b3e5a7cf69e4e226cd0247.37.1
  • Dataflow base image: us-central1-docker.pkg.dev/external-snap-ci-github-gigl/public-gigl/gigl-dataflow-base:ea5cafee34c508ea98b3e5a7cf69e4e226cd0247.37.1
  • Builder image: us-central1-docker.pkg.dev/external-snap-ci-github-gigl/gigl-base-images/gigl-builder:ea5cafee34c508ea98b3e5a7cf69e4e226cd0247.37.1

Updated dep_vars.env with new image names.
Updated .github/cloud_builder/run_command_on_pr_cloud_build.yaml with new builder image.

@svij-sc svij-sc marked this pull request as ready for review August 29, 2025 21:44
@svij-sc svij-sc enabled auto-merge August 29, 2025 21:44
Copy link
Collaborator

@mkolodner-sc mkolodner-sc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

# File ".../python3.9/site-packages/piptools/repositories/pypi.py", line 452, in allow_all_wheels
# self.finder.find_all_candidates.cache_clear()
# AttributeError: 'function' object has no attribute 'cache_clear'
# Thus, we fix the pip version to 25.0.1.
# Note_2: Even though some wheels are garded behind conditionals i.e. only use this if platform = linux;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: guarded*

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants