-
Notifications
You must be signed in to change notification settings - Fork 6
Lock pip-compile version + follow up (#279 ) regen reqs / images #289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: Shubham Vij <[email protected]>
Co-authored-by: Shubham Vij <[email protected]>
Co-authored-by: Shubham Vij <[email protected]>
Co-authored-by: Shubham Vij <[email protected]>
Co-authored-by: Shubham Vij <[email protected]>
GiGL Automation@ 20:05:41UTC : Starting to generate hashed requirements from |
GiGL Automation@ 20:08:39UTC : Built and pushed updated requirements files. |
Co-authored-by: Shubham Vij <[email protected]>
GiGL Automation@ 20:12:51UTC : Starting to build base images for CUDA and CPU. |
GiGL Automation@ 20:33:00UTC : Built and pushed new images:
Updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
# File ".../python3.9/site-packages/piptools/repositories/pypi.py", line 452, in allow_all_wheels | ||
# self.finder.find_all_candidates.cache_clear() | ||
# AttributeError: 'function' object has no attribute 'cache_clear' | ||
# Thus, we fix the pip version to 25.0.1. | ||
# Note_2: Even though some wheels are garded behind conditionals i.e. only use this if platform = linux; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: guarded*
Scope of work done
This PR was originally gong to be just a follow up from: https://github.com/Snapchat/GiGL/pull/279/files#r2289567700
But, noticed that w/ the new version of
pip-tools
it is not able to compile MAC requirements anymore as it was before.Where is the documentation for this feature?: N/A
Did you add automated tests or write a test plan?
Updated Changelog.md? NO
Ready for code review?: NO