Fix issue Call to memset
may be deleted
#915
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix this problem, the call to
memset
should be replaced with a function that is guaranteed not to be optimized away by the compiler. The best standard solution is to usememset_s
(from C11), which is specifically designed for this purpose. Ifmemset_s
is not available on all target platforms, a fallback to a platform-specific secure zeroing function (such asexplicit_bzero
orSecureZeroMemory
on Windows) or a custom implementation may be necessary. However, since we can only edit the code shown, the best fix is to replacememset
withmemset_s
and include the required header (#include <string.h>
, already present). Ifmemset_s
is not available, the build will fail, prompting the developer to provide an appropriate implementation.Steps:
memset(block, '\0', sizeof(block));
withmemset_s(block, sizeof(block), 0, sizeof(block));
insrc/sha1.c
.<string.h>
is already included.