-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Support sharded pubsub commands #2887
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* Support sharded pubsub * Support sharded pubsub * fix api * fix enum * fix api --------- Co-authored-by: Marc Gravell <[email protected]>
* Support sharded pubsub * Support sharded pubsub * fix api * fix enum * fix api * proposed refactor to single-field implementation * RedisDatabase needs to use SPUBLISH/PUBLISH correctly * support ssub on CLIENT response * add to features; fixup shipped etc --------- Co-authored-by: xli <[email protected]>
hi @mgravell , |
important TODOs before final merge:
|
hey @mgravell , i think this branch fixes and tests reconnect logic as well as testing for hashslot migrations. the only item remaining is unsubscribe-all logic; what should be the expected behaviour with unsubscribe-all??
|
|
||
private void MigrateSlotForTestShardChannel(bool rollback) | ||
{ | ||
int hashSlotForTestShardChannel = 7177; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
^ This needs to be separated per test suite
Hey, This PR has changed the channel type passed to the action in
|
Continuation of #2498