Namespace oops helper methods #7
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The rake namespace DSL does nothing to excanpsulate defined methods. So we can either refactor oops tasks into modules or simply rename the private helpers to lower the chance of collisions on the global scope.
I'm not as concerned with the accuracy of these descriptions as I am with their existance, so that oops tasks will be listed by rake -T
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rake methods like
namespaceandtaskdon't actually scope down the context on which methods are described.s3_urlfor instance is creating a top level method that I once actually bumped into in a project (was doing some imgix work).This is the laziest possible way to fix that problem. Sorry, busy ;)