Rock: Field Settings Refresh Lite #2266
Draft
+12,973
−1,243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shervElmi
force-pushed
the
rock/field-settings-refresh-lite
branch
6 times, most recently
from
cb861ce to
61a3fec
Compare
…ld-settings-refresh-lite
…nce formula UI styling - Add event handler to focus on calculation input when inserting a field - Add box-shadow to formula elements for better visibility - Adjust padding and spacing in formula components - Move font-weight to hover state for better visual hierarchy - Remove max-height constraint for search field
…and fix height auto-adjustment
… fix sidebar collapse behavior
- Switched from jQuery to vanilla JS for DOM manipulations (getElementById, insertAdjacentHTML, closest, style.height) in the `addFieldLogicRow` success callback. This modernizes the codebase and can offer performance benefits. - Implemented dynamic setting of the newly added logic rule's display text using `logicRow.dataset.ruleText`, improving UI feedback. - Retained jQuery for the `fadeIn` animation to maintain existing visual behavior.
- Introduce new flexbox utility classes for horizontal stacking: - `.frm-h-stack` (gap: --gap-2xs) - `.frm-h-stack-sm` (gap: --gap-xs) - Add new margin utility class `.frm-m-2xs`. - Add new line-height utility class `.frm-leading-none`. - Adjust right padding in `.frm-settings-panel` to `var(--gap-xs)` to better accommodate scrollbars. - Ensure `.frm_logic_rows` in form settings widget correctly sets `height: auto` when the "Add Logic" link is hidden.
- Restructured SCSS for `.windows` scrollbar styles by nesting child pseudo-elements for better readability and organization. - Applied `!important` to `overflow-y: auto` in `.frm-scrollbar-wrapper` to ensure consistent scroll behavior. - Reorganized WebKit scrollbar styles within `.frm-scrollbar-wrapper` by nesting pseudo-elements (`-track`, `-thumb`, and `-thumb:hover`). This enhances maintainability and correctly scopes the thumb's hover effect.
- Change AI form gradient ID from '#a' to '#frm_icon_6c9d4b7e' for better specificity - Replace drag icon with a more modern outlined version - Add new simple pencil icon for improved UI consistency
- Add new utility class .frm-hr for consistent horizontal rules - Update box shadows from xs to sm for better visual depth - Improve field options styling with consistent spacing and borders - Add new SVG size class .frm_svg24 for 24px icons - Refine bulk edit link display with flex layout - Enhance form field grid and flex utilities - Add .frm-grow utility class for flexible layouts - Improve single option element styling - Fix sortable field options with proper spacing and borders
- Import isVisible utility from core/utils - Add initVisibilityObserver method to handle conditional visibility - Track parent element visibility changes up to 3 levels deep - Update component styles when elements become visible - Simplify tracker positioning with consistent left and width calculations
- Replace left/right value approach with options array for better flexibility - Restore dynamic ID generation with field_name and index - Maintain backward compatibility with existing components - Improve default value handling through is_default_checked
- Update images-dropdown.php to pass image attributes to text-toggle component - Add classes and custom attributes to component options - Improve empty value handling in text-toggle.php with !empty() checks - Add data-value and custom attributes to labels for proper styling - Preserve original image dropdown functionality with the text toggle component
- Simplify attribute passing in images-dropdown by using input_attrs_str directly - Remove redundant input-classname and data-fid parameters - Make input type conditional based on presence of input_attrs_str - Improve attribute output with fallback to field_name when needed - Consolidate attribute handling for better code maintenance
- Move "Add Option" button into each option item for improved UX - Deprecate get_add_option_string() method in FrmFieldType class - Remove standalone add option container from field-options.php - Adjust single-option input width to accommodate the new inline button - Clean up related CSS in icon-font stylesheet
- Insert new options after the current option instead of appending to the end - Prevent deletion of the last option by disabling its remove button - Add check to ensure at least two options remain when deleting - Enable remove buttons after adding new options to maintain UI consistency - Reorganize code for better readability and maintenance
- Fix logical condition in text-toggle component for proper radio type assignment - Refactor radio-component.js to improve code organization with new initRadio() method - Move event listener for field addition to constructor for better scoping - Enhance "Use separate values" UI in radio-images.php with improved styling - Add horizontal stack and spacing classes for better visual alignment
- Add options_count tracking in FrmFieldsHelper for better option handling - Replace jQuery selector with native querySelector for remove button management - Use forEach to handle multiple disabled remove buttons properly - Speed up option removal animations by changing from 'slow' to 'fast' - Clean up unnecessary comments and improve code clarity
- Disable option removal when only one option exists to prevent empty fields - Add utility class frm-gap-xs! for more precise spacing control - Improve checkbox and radio input alignment in option rows - Add consistent padding to radio display format container - Enhance spacing in "Use separate values" checkbox UI - Update SCSS to properly style both radio and checkbox inputs in options
- Update SVG icon to use currentColor for better theme compatibility - Enhance image option styling with updated colors and spacing - Improve checkbox and radio alignment in "Use separate values" option - Add new utility classes: frm-h-stack-xs and frm-content-center - Fix margin and spacing in field options for better visual hierarchy - Adjust form elements width calculations for consistent alignment - Remove redundant CSS rules and optimize selector specificity
- Replace strict comparison with loose comparison for field values - Add backwards compatibility styling for ranking field image boxes - Strengthen CSS specificity with !important flags for option margins and widths - Prevent hidden fields from affecting grid layout with :not(.frm_hidden) selector
- Add SVG icons pack ID for better DOM organization - Create gradient button styling with background-clip and positioning - Add new utility classes for borders, spacing, and sizing - Add frm-rounded-6 class for 6px border radius - Create frm-max-w-fit utility for fit-content max width - Add 12px bottom margin utility class - Include frm-px-xs utility for consistent extra small horizontal padding - Add frm-font-normal utility for 400 weight text - Improve grid alignment with center content - Fix SVG icons display in form editor by excluding from hide selector
- Enhance webpack configuration to watch all formidable plugins - Update file watching paths with wildcards for cross-plugin development - Add smooth transition to gradient button hover states - Reduce hover opacity from 0.7 to 0.5 for better contrast - Clean up BrowserSync configuration for better code organization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Design
https://www.figma.com/design/ZAjXiGgJdMjrX8Mk61Obnf/Field-Settings-Refresh?node-id=0-1&t=7YgG29K5IThVZQ3G-1