Add a text that clarifies whether a field column is for field value or label #2326
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Walkthrough
The update introduces a new private static method to the `FrmEntriesController` class for formatting field names in entry list columns. This method, `maybe_format_field_name_for_column_title`, appends either "(Value)" or "(Label)" to the truncated field name for specific field types ('select', 'radio', or 'checkbox'), depending on a boolean parameter. The `add_field_cols` method is refactored to utilize this new method, ensuring consistent and centralized formatting of field names for these option fields.
## Changes
| File(s) | Change Summary |
|----------------------------------------------|---------------------------------------------------------------------------------------------------------------------|
| classes/controllers/FrmEntriesController.php | Added private static method for conditional field name formatting; refactored `add_field_cols` to use this method. |
## Suggested labels
`run analysis`, `run tests`
## Suggested reviewers
- truongwp
- Crabcyborg📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (5)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
truongwp
reviewed
Apr 28, 2025
truongwp
approved these changes
Apr 28, 2025
There was a problem hiding this comment.
Thanks @AbdiTolesa. This looks good.
@Crabcyborg Do we need to shorten the field label because we append some string?
Crabcyborg
reviewed
Apr 28, 2025
| } | ||
|
|
||
| $columns[ $form_id . '_' . $col_id ] = FrmAppHelper::truncate( $field->name, 35 ); | ||
| $columns[ $form_id . '_' . $col_id ] = self::maybe_format_field_name_for_title( $field, $has_separate_value, false ); |
There was a problem hiding this comment.
@AbdiTolesa It seems to me that the condition isn't really $has_separate_value, but $has_separate_value && ! $is_post_status (above).
When it is post status, it doesn't add a second column, so there isn't really a need in adding (Value) in that case.
Maybe another variable would be more clear. Something like $include_column_for_sep_val = $has_separate_value && ! $is_post_status;?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Slack conversation: https://strategy11.slack.com/archives/C799A2R61/p1745575960753219