Use "found" parameter in wp_cache_get

[andrewklimek]

I've seen views that make heavy use of frm-stats where this returns hundreds of empty arrays that don't get cached, because the current check which won't cache empty arrays.

[coderabbitai]

Walkthrough

The cache retrieval logic in the check_cache method of the FrmDb class was updated. The method now uses an explicit cache existence check using the $found flag from wp_cache_get, instead of relying on the emptiness of the cached result, to determine whether to return cached data.

Changes

File	Change Summary
classes/models/FrmDb.php	Updated check_cache method to use $found flag from wp_cache_get for cache existence check.

Sequence Diagram(s)

sequenceDiagram
    participant Caller
    participant FrmDb
    participant WP_Cache

    Caller->>FrmDb: check_cache(cache_key, group, query, type, time)
    FrmDb->>WP_Cache: wp_cache_get(cache_key, group, false, &found)
    alt Cache key exists (found !== false)
        FrmDb-->>Caller: return cached result
    else Query is empty
        FrmDb-->>Caller: return cached result
    else
        FrmDb->>Caller: proceed with DB query logic
    end

Loading

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 11ab220 and 47d26bc.

📒 Files selected for processing (1)

• classes/models/FrmDb.php (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (2)

• GitHub Check: Psalm
• GitHub Check: Run ESLint

🔇 Additional comments (1)

classes/models/FrmDb.php (1)

659-661: LGTM! Excellent fix for empty array caching issue.

This change correctly addresses the core problem where empty arrays weren't being cached. Using the $found parameter from wp_cache_get is the proper way to determine cache existence, regardless of whether the cached value is empty or not. This should significantly improve performance for views using frm-stats that return legitimate empty results.

The implementation is solid:

• Proper initialization of $found variable
• Correct usage of the fourth parameter in wp_cache_get
• Maintains existing behavior for empty queries while fixing the caching logic

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.