Skip to content

resolved the issue to export app, it requred --format argument which … issue #727 #763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

nabi-noor
Copy link

@nabi-noor nabi-noor commented Jun 25, 2025

name: Noor Nabi
about: Fix to buid app as html by default and if pdf needs to be generated --format pdf should be called in the export command
title: fix/build-script
labels: bug
assignees: ''

Related Issue
Fixes #(issue)

Description of Changes
A clear and concise description of the changes made in this pull request.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • New example
  • Test improvement

Testing
Please describe the tests that you ran to verify your changes. Include screenshots/videos.
image
The above image shows a successful export for earthquake example
Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have run my code against examples and ensured no errors
  • Any dependent changes have been merged and published in downstream modules

@nabi-noor
Copy link
Author

#727 this issue is linked to the bug. To test the issue you need to run preswald export command and it should run and create the build successfully instead of creashing and asking to provide format of the export

@nabi-noor nabi-noor changed the title resolved the issue to export app, it requred --format argument which … resolved the issue to export app, it requred --format argument which … issue #727 Jun 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant