Skip to content

Source template feature for Timestamp parsing #5552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jul 10, 2025
Merged

Source template feature for Timestamp parsing #5552

merged 13 commits into from
Jul 10, 2025

Conversation

sumoanema
Copy link
Collaborator

Purpose of this pull request

This pull request is to update timestamp parsing feature doc with some more details and making source template with timestamp parsing to redirect to it.

Select the type of change

  • Minor Changes - Typos, formatting, slight revisions
  • Update Content - Revisions, updating sections
  • New Content - New features, sections, pages, tutorials
  • Site and Tools - .clabot, version updates, maintenance, dependencies, new packages for the site (Docusaurus, Gatsby, React, etc.)

Ticket (if applicable)

https://sumologic.atlassian.net/browse/SUMO-258774

@cla-bot cla-bot bot added the cla-signed Contributor approved, listed in .clabot file label Jul 4, 2025
Copy link
Collaborator

@jpipkin1 jpipkin1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sumoanema, this looks very good. It just needs a few minor updates.

@JV0812 JV0812 requested a review from jpipkin1 July 8, 2025 12:14
Copy link
Collaborator

@jpipkin1 jpipkin1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, @JV0812. It looks great.

@jpipkin1 jpipkin1 dismissed their stale review July 8, 2025 13:37

Re-reviewed and approved.

Copy link
Collaborator

@JV0812 JV0812 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@kimsauce kimsauce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sumoanema , i've proposed changes to your PR that utilizes a /reuse file, includes a few minor fixes, adds cross-references between the general and OTRM time refs, and fixes an extraneous markup in an image.

@sumoanema
Copy link
Collaborator Author

sumoanema commented Jul 9, 2025

Thanks @kimsauce , the PR #5566 looks perfect. Should we close this PR. And can you merge the other PR

@kimsauce
Copy link
Collaborator

kimsauce commented Jul 9, 2025

Thanks @kimsauce , the PR #5566 looks perfect. Should we close this PR. And can you merge the other PR

thanks for reviewing! I've set it up so that it will merge into yours once approved -- i'll do that now.

* Replace otelcol timestamp /reuse reference

* cross-references

* Update docs/send-data/opentelemetry-collector/remote-management/source-templates/postgresql/index.md

* Update docs/send-data/opentelemetry-collector/remote-management/source-templates/rabbitmq/index.md

* Update docs/send-data/opentelemetry-collector/remote-management/source-templates/redis/index.md

* Update docs/send-data/opentelemetry-collector/remote-management/source-templates/otrm-time-reference.md

Co-authored-by: John Pipkin (Sumo Logic) <[email protected]>

* Update docs/reuse/apps/opentelemetry/timestamp-parsing.md

Co-authored-by: John Pipkin (Sumo Logic) <[email protected]>

---------

Co-authored-by: John Pipkin (Sumo Logic) <[email protected]>
@kimsauce kimsauce self-requested a review July 9, 2025 19:51
@sumoanema
Copy link
Collaborator Author

@kimsauce thanks !! Will track this PR then.

@JV0812 JV0812 dismissed kimsauce’s stale review July 10, 2025 05:32

Incorporated the changes. Thanks Kim!

@JV0812 JV0812 added this pull request to the merge queue Jul 10, 2025
Merged via the queue into main with commit b348bea Jul 10, 2025
7 checks passed
@JV0812 JV0812 deleted the otelTimestamp branch July 10, 2025 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed Contributor approved, listed in .clabot file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants