-
Notifications
You must be signed in to change notification settings - Fork 224
Source template feature for Timestamp parsing #5552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
...send-data/opentelemetry-collector/remote-management/source-templates/otrmTimestampParsing.md
Outdated
Show resolved
Hide resolved
...send-data/opentelemetry-collector/remote-management/source-templates/otrmTimestampParsing.md
Outdated
Show resolved
Hide resolved
...send-data/opentelemetry-collector/remote-management/source-templates/otrmTimestampParsing.md
Outdated
Show resolved
Hide resolved
...send-data/opentelemetry-collector/remote-management/source-templates/otrmTimestampParsing.md
Outdated
Show resolved
Hide resolved
...send-data/opentelemetry-collector/remote-management/source-templates/otrmTimestampParsing.md
Outdated
Show resolved
Hide resolved
...send-data/opentelemetry-collector/remote-management/source-templates/otrmTimestampParsing.md
Outdated
Show resolved
Hide resolved
...send-data/opentelemetry-collector/remote-management/source-templates/otrmTimestampParsing.md
Outdated
Show resolved
Hide resolved
...send-data/opentelemetry-collector/remote-management/source-templates/otrmTimestampParsing.md
Outdated
Show resolved
Hide resolved
...send-data/opentelemetry-collector/remote-management/source-templates/otrmTimestampParsing.md
Outdated
Show resolved
Hide resolved
...send-data/opentelemetry-collector/remote-management/source-templates/otrmTimestampParsing.md
Outdated
Show resolved
Hide resolved
...send-data/opentelemetry-collector/remote-management/source-templates/otrmTimestampParsing.md
Outdated
Show resolved
Hide resolved
...send-data/opentelemetry-collector/remote-management/source-templates/otrmTimestampParsing.md
Outdated
Show resolved
Hide resolved
...send-data/opentelemetry-collector/remote-management/source-templates/otrmTimestampParsing.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sumoanema, this looks very good. It just needs a few minor updates.
Co-authored-by: John Pipkin (Sumo Logic) <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, @JV0812. It looks great.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @sumoanema , i've proposed changes to your PR that utilizes a /reuse file, includes a few minor fixes, adds cross-references between the general and OTRM time refs, and fixes an extraneous markup in an image.
* Replace otelcol timestamp /reuse reference * cross-references * Update docs/send-data/opentelemetry-collector/remote-management/source-templates/postgresql/index.md * Update docs/send-data/opentelemetry-collector/remote-management/source-templates/rabbitmq/index.md * Update docs/send-data/opentelemetry-collector/remote-management/source-templates/redis/index.md * Update docs/send-data/opentelemetry-collector/remote-management/source-templates/otrm-time-reference.md Co-authored-by: John Pipkin (Sumo Logic) <[email protected]> * Update docs/reuse/apps/opentelemetry/timestamp-parsing.md Co-authored-by: John Pipkin (Sumo Logic) <[email protected]> --------- Co-authored-by: John Pipkin (Sumo Logic) <[email protected]>
@kimsauce thanks !! Will track this PR then. |
Purpose of this pull request
This pull request is to update timestamp parsing feature doc with some more details and making source template with timestamp parsing to redirect to it.
Select the type of change
Ticket (if applicable)
https://sumologic.atlassian.net/browse/SUMO-258774