Enable controls while playing ad #71
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
For the default UI, I suggest we also hide the disabled buttons while playing an ad (i.e. the seek buttons in the center, and the settings menu button at the top).
We may also want to tweak the default UI some more while playing an ad. For example, the Web UI moves the seek bar all the way to the bottom and shrinks the buttons a little bit, to give as much space as possible to the ad.
| Web UI playing content | Web UI playing ad |
|---|---|
 |
 |
MattiasBuelens
force-pushed
the
feature/enable-controls-while-playing-ad
branch
from
cf73b65 to
c240166
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.