Skip to content

Conversation

kjuke-dolby
Copy link
Contributor

No description provided.

@kjuke-dolby kjuke-dolby requested a review from a team as a code owner July 1, 2025 01:25
@MattiasBuelens MattiasBuelens requested a review from Danesz July 1, 2025 08:59
@MattiasBuelens
Copy link
Collaborator

CCing @Danesz as our resident Flutter expert. 😁

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There doesn't seem to be anything THEOlive specific in this guide. Maybe we should move it to the main Flutter SDK docs instead?

Those guides are in the flutter-theoplayer-sdk repo though, so you'll have to re-open this PR there.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding Daniel as a reviewer. I think the VOD screenshots I use and the more general nature of styling for the THEOplayer may be throwing off the THEOlive connection.

I think your suggestions would work good though because I definitely would have wanted to see some in-depth code examples when I first started learning Flutter and Dart to work on documentation. I will create a PR there and I'm guessing make a link to them here in the THEOlive Flutter playback documentation like with the minimal app setup.

I'm guessing styling will be omitted from here completely as THEOlive Flutter playback styling applies for Millicast, HLS, DASH, and THEOlive.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MattiasBuelens and @Danesz

The Flutter THEOplayer SDK doc styling addition PR is here: THEOplayer/flutter-theoplayer-sdk#109

I could not add you two as reviewers or assign it to myself due to not having access to the repository.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have also opened this PR to update the deprecated methods from the Flutter minimal app setup instructions: THEOplayer/flutter-theoplayer-sdk#110 (removes the old 'setSource()' and 'getView()')

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants