Skip to content

refactor: jsdoc and docs for RouteOptions #4317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

KirillTregubov
Copy link

This is a draft based on this conversation.

Currently only implements jsdocs for RouteOptionsType, which is used in the createRoute function.

Any feedback / review is highly appreciated! Feel free to leave some anytime.

@schiller-manuel
Copy link
Contributor

ideally we can eventually generate the docs from the code.
@crutchcorn which format should we adhere to in the code to make this work?

@KirillTregubov
Copy link
Author

ideally we can eventually generate the docs from the code. @crutchcorn which format should we adhere to in the code to make this work?

I tried to keep all the jsdocs as similar to the current docs website content as possible. I may have shortened some of them because they had multiple paragraphs of description, but if this is the route you want to take, I can amend those few instances to include everything.

It would be ideal if you can settle on a format that works best. We can test it with RouteOptions, and then I will implement it for the other APIs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants