Skip to content

Conversation

latiefdole
Copy link

What is the problem?

The current version of this package has dependency constraints in composer.json that make it incompatible with Laravel 11 and Laravel 12.

Attempting to install it in a modern Laravel project results in a composer dependency conflict, primarily due to the outdated requirements for illuminate/support and illuminate/database which are locked to older framework versions.

How does this PR solve the problem?

This Pull Request resolves the incompatibility by updating the composer.json file to allow for modern Laravel versions.

Specifically, the following changes were made:

  • The required PHP version was updated to ^8.2.
  • Version constraints for illuminate/database, illuminate/support, and illuminate/http were updated to ^11.0|^12.0.
  • Development dependencies like orchestra/testbench and phpunit were also updated to align with the new framework versions.
  • (Opsional, tambahkan ini jika Anda memperbaiki kode) Additionally, any breaking code changes resulting from these dependency updates have been addressed to ensure full functionality.

How can this be tested?

  1. Create a new Laravel 12 project.
  2. Add this forked repository and branch to the project's composer.json.
  3. Run composer update.
  4. Confirm that it resolves and installs dependencies without any conflicts.

Context

This update is crucial for users of the tapp/filament-survey plugin who wish to use it on modern Laravel applications, as this package is its core dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant