Skip to content

Overlay Permission: display explanatory dialog for Android > R #12253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

Profpatsch
Copy link
Contributor

On Android > R, ACTION_MANAGE_OVERLAY_PERMISSION always brings the user to the app selection screen.

https://developer.android.com/about/versions/11/privacy/permissions#manage_overlay

This is highly confusing behaviour from the system, so let’s add an instruction before navigating to the settings menu.

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Before/After Screenshots/Screen Record

newpipe_popup_alert.mp4

Fixes the following issue(s)

No issue afaik

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

On Android > R, ACTION_MANAGE_OVERLAY_PERMISSION always brings the
user to the app selection screen.

https://developer.android.com/about/versions/11/privacy/permissions#manage_overlay

This is highly confusing behaviour from the system, so let’s add an
instruction before navigating to the settings menu.
@github-actions github-actions bot added the size/medium PRs with less than 250 changed lines label May 5, 2025
@Profpatsch Profpatsch changed the title Permission: display explanatory dialog for Android > R Overlay Permission: display explanatory dialog for Android > R May 5, 2025
Copy link

sonarqubecloud bot commented May 5, 2025

@ShareASmile ShareASmile added feature request Issue is related to a feature in the app ready for review Most of the work is done, PR is now ready for a review labels Jun 18, 2025
@@ -2,13 +2,15 @@

import android.Manifest;
import android.app.Activity;
import android.app.AlertDialog;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
import android.app.AlertDialog;
import androidx.appcompat.app.AlertDialog;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Issue is related to a feature in the app ready for review Most of the work is done, PR is now ready for a review size/medium PRs with less than 250 changed lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants