Skip to content

Call AWS.config.update after parsing region #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

sonya
Copy link

@sonya sonya commented Mar 22, 2016

The README suggests that the options.region parameter is not required when specifying an arn for the lambda_deploy task. However, I was finding this not to be the case, and it looked like what was happening was the region was being set before it was parsed from the arn. This PR attempts to fix this.

@Tim-B
Copy link
Owner

Tim-B commented May 31, 2016

My apologies for the delay in replying to this. Would it be possible to add unit tests to demonstrate this fixes the issue? Otherwise I might break it again in future ;)

@sonya
Copy link
Author

sonya commented Jun 6, 2016

Thanks for looking at this. I added a unit test which indeed fails if the previous commit is reverted.

@rnowosielski
Copy link

@Tim-B how about merging this? I spent quite some time today trying to figure out why the tooling thinks my lambda doesn't exist even though it did exists :)

@mahirk
Copy link

mahirk commented Jan 3, 2019

@Tim-B Any possible update for the above?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants