Skip to content

Added lambda_package option to map files into the zip archive (rename) #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lukas-gitl
Copy link

No description provided.

@Tim-B
Copy link
Owner

Tim-B commented Jun 1, 2016

Thanks for the pull request! Would you mind explaining the use case you see for this a little more?

Also, it looks like the unit tests could probably cover a bit more of your new functionality.

@lukas-gitl
Copy link
Author

This is to allow for different environment configurations in the packages.

I think this project would benefit from coverage with the tests... It's covered, but hard to see when stuff gets uncovered in the future.

@keen99
Copy link

keen99 commented Oct 19, 2016

The use case here, as I see it (and could use it right now) would be to pass different environment configs (or other files or any other reason) into the package deployed.

For example - I want to deploy the "dev" version with the dev.json config file, to function: dev. for "prod" I want to include the prod.json and send that version of the package to function: prod

I need my code to behave differently (talk to different resources, whatever) for different environments.

While I suppose I could package multiple index.js files and set handler: to consume them (I'm speculating), it's a bit less flexible and specific.

@lukas-gitl does that match up with your use case?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants