feat(llm): add unit tests #2209
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XXL
eliandoran
reviewed
Jun 8, 2025
|
insert elmo fire gif here |
…te with unit tests better
…ass" This reverts commit 95a33ba.
closer to fixing... closer... very close to passing...
keep working
perfectra1n
force-pushed
the
feat/llm-unit-tests
branch
from
3fbda15 to
41906ab
Compare
perfectra1n
commented
Jun 9, 2025
| @@ -158,6 +158,11 @@ function handleException(e: unknown | Error, method: HttpMethod, path: string, r | |||
|
|
|||
| log.error(`${method} ${path} threw exception: '${errMessage}', stack: ${errStack}`); | |||
|
|
|||
| // Skip sending response if it's already been handled by the route handler | |||
| if ((res as unknown as { triliumResponseHandled?: boolean }).triliumResponseHandled || res.headersSent) { | |||
There was a problem hiding this comment.
I need to be able to send my own responses when using the asyncApiRoute - so I figured this was the best way to go about it...
eliandoran
approved these changes
Jun 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.... and resolve some issues that creating the unit tests found 😂