-
-
Notifications
You must be signed in to change notification settings - Fork 155
feat(llm): add unit tests #2209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to solve the type errors.
insert elmo fire gif here |
…te with unit tests better
…ass" This reverts commit 95a33ba.
closer to fixing... closer... very close to passing...
keep working
3fbda15
to
41906ab
Compare
@@ -158,6 +158,11 @@ function handleException(e: unknown | Error, method: HttpMethod, path: string, r | |||
|
|||
log.error(`${method} ${path} threw exception: '${errMessage}', stack: ${errStack}`); | |||
|
|||
// Skip sending response if it's already been handled by the route handler | |||
if ((res as unknown as { triliumResponseHandled?: boolean }).triliumResponseHandled || res.headersSent) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I need to be able to send my own responses when using the asyncApiRoute
- so I figured this was the best way to go about it...
.... and resolve some issues that creating the unit tests found 😂