Skip to content

feat(llm): add unit tests #2209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 24 commits into from
Jun 10, 2025
Merged

feat(llm): add unit tests #2209

merged 24 commits into from
Jun 10, 2025

Conversation

perfectra1n
Copy link
Member

@perfectra1n perfectra1n commented Jun 8, 2025

.... and resolve some issues that creating the unit tests found 😂

@dosubot dosubot bot added the size:XXL This PR changes 1000+ lines, ignoring generated files. label Jun 8, 2025
@perfectra1n perfectra1n changed the title Feat/llm unit tests feat(llm): add unit tests Jun 8, 2025
@eliandoran eliandoran marked this pull request as draft June 8, 2025 07:50
Copy link
Contributor

@eliandoran eliandoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to solve the type errors.

@perfectra1n
Copy link
Member Author

insert elmo fire gif here

@perfectra1n perfectra1n marked this pull request as ready for review June 8, 2025 21:42
@perfectra1n perfectra1n force-pushed the feat/llm-unit-tests branch from 3fbda15 to 41906ab Compare June 9, 2025 00:10
@@ -158,6 +158,11 @@ function handleException(e: unknown | Error, method: HttpMethod, path: string, r

log.error(`${method} ${path} threw exception: '${errMessage}', stack: ${errStack}`);

// Skip sending response if it's already been handled by the route handler
if ((res as unknown as { triliumResponseHandled?: boolean }).triliumResponseHandled || res.headersSent) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to be able to send my own responses when using the asyncApiRoute - so I figured this was the best way to go about it...

@eliandoran eliandoran added this to the v0.95.0 milestone Jun 10, 2025
@eliandoran eliandoran merged commit 36f0de8 into develop Jun 10, 2025
10 checks passed
@eliandoran eliandoran deleted the feat/llm-unit-tests branch June 10, 2025 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XXL This PR changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants