Skip to content

New sound icon #2147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Conversation

wiktorlaskowski
Copy link
Contributor

I want to change the icon for the URL Playback extension; I think the current one is poorly designed.

I made it way more complex and detailed and intricate, like what I did with the images extension

@github-actions github-actions bot added the pr: other Pull requests that neither add new extensions or change existing ones label Jun 4, 2025
@SharkPool-SP
Copy link
Collaborator

Maybe this is a personal opinion but thumbnails on the gallery should be relatively simple and clear.

Maybe remove the dots in the background and spread out the icons in the center?

@wiktorlaskowski
Copy link
Contributor Author

Maybe this is a personal opinion but thumbnails on the gallery should be relatively simple and clear.

Maybe remove the dots in the background and spread out the icons in the center?

Done.
sound

@SharkPool-SP
Copy link
Collaborator

could you also make the outlines thinner and the bottom purple slightly lighter? If so, then I think ill like it more

@wiktorlaskowski
Copy link
Contributor Author

could you also make the outlines thinner and the bottom purple slightly lighter? If so, then I think ill like it more

sound

@wiktorlaskowski
Copy link
Contributor Author

could you also make the outlines thinner and the bottom purple slightly lighter? If so, then I think ill like it more

Done

@SharkPool-SP
Copy link
Collaborator

i meant like, all the outlines, including the sparkles and icons

@wiktorlaskowski
Copy link
Contributor Author

i meant like, all the outlines, including the sparkles and icons

Woah. not so many changes! I am ready now.

@SharkPool-SP
Copy link
Collaborator

huh

@wiktorlaskowski
Copy link
Contributor Author

huh

Ok, now since you are a collaborator, then do the merge.

@SharkPool-SP
Copy link
Collaborator

huh

Ok, now since you are a collaborator, then do the merge.

you didnt commit the new change tho?

@wiktorlaskowski
Copy link
Contributor Author

huh

Ok, now since you are a collaborator, then do the merge.

you didnt commit the new change tho?

The last one to remove outline strength I didn't do because this already has 3 iterations!

@SharkPool-SP
Copy link
Collaborator

And I'm asking for a 4th?

@wiktorlaskowski
Copy link
Contributor Author

And I'm asking for a 4th?

Yeah. Please do the merge.

@wiktorlaskowski
Copy link
Contributor Author

Anyone here???

@wiktorlaskowski
Copy link
Contributor Author

If no one responds, then I will close the pr.

@CST1229
Copy link
Collaborator

CST1229 commented Jun 6, 2025

If no one responds, then I will close the pr.

be patient

@Brackets-Coder
Copy link
Contributor

@wiktorlaskowski most of the pull requests here haven't been reviewed in months. It takes time.

@wiktorlaskowski
Copy link
Contributor Author

@wiktorlaskowski most of the pull requests here haven't been reviewed in months. It takes time.

Can you please review it with an accepted review? Just one more if one review gets in and I can forcefully merge the repositories without Garbomuffin.

@wiktorlaskowski
Copy link
Contributor Author

If no one responds, then I will close the pr.

be patient

Can you please do an accepting review?

@Brackets-Coder
Copy link
Contributor

If no one responds, then I will close the pr.

be patient

Can you please do an accepting review?

You seem to really want a review as soon as possible. First, understand that none of us review pull requests 24/7 as a full time job and we're all volunteers with lives outside Turbowarp. Second, all pull requests require 2 approving reviews before any kind of merge. Third, see #1721 for more information regarding PR review times.

@SharkPool-SP
Copy link
Collaborator

Closing because of #2149

@wiktorlaskowski wiktorlaskowski deleted the patch-2 branch June 10, 2025 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: other Pull requests that neither add new extensions or change existing ones
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants