Implement Turing.Inference.getlogp_external
#39
Merged
+41
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
penelopeysm
force-pushed
the
py/getlogp-external
branch
from
90d0ec7 to
fd58050
Compare
|
SliceSampling.jl documentation for PR #39 is available at: |
penelopeysm
force-pushed
the
py/getlogp-external
branch
from
22a0360 to
2391a06
Compare
Red-Portal
approved these changes
Jul 20, 2025
There was a problem hiding this comment.
Thanks @penelopeysm . I have no particular comment and it all looks good to me. Feel free to merge this when you see fit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following on from TuringLang/Turing.jl#2616 this removes the need to re-evaluate the model to obtain logp.
Can't be merged yet since that Turing PR needs to be merged and released.