Skip to content

ongoing bugs/changes to charmpandas installation instructions #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

ongoing bugs/changes to charmpandas installation instructions #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ Installation

5. Install charmpandas::

git clone https://github.com/adityapb/charmpandas.git
git clone https://github.com/UIUC-PPL/charmpandas.git
cd charmpandas/src
export CHARMDIR=<charm++ home directory>
export XXHASH_DIR=<xxhash home directory>
Expand Down
4 changes: 2 additions & 2 deletions src/reduction.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,10 +45,10 @@ AggregateReductionMsg* create_reduction_msg(int result_name, int table_size, cha
int total_size = sizeof(AggregateReductionMsg) + table_size + options_size;
void* buffer = ::operator new(total_size);
AggregateReductionMsg* msg = new (buffer) AggregateReductionMsg(result_name, table_size, options_size);
char* msg_options = reinterpret_cast<char*>(buffer + sizeof(AggregateReductionMsg));
char* msg_options = reinterpret_cast<char*>((char*)buffer + sizeof(AggregateReductionMsg));
if (table_size > 0)
{
char* msg_table = reinterpret_cast<char*>(buffer + sizeof(AggregateReductionMsg) + options_size);
char* msg_table = reinterpret_cast<char*>((char*)buffer + sizeof(AggregateReductionMsg) + options_size);
std::memcpy(msg_table, table, table_size);
}
std::memcpy(msg_options, options, options_size);
Expand Down