feature/refresh_emission_view_noxmasscems #10

ergjustin · 2023-11-01T03:13:32Z

Ticket

Refactor Refresh Emissions Views Database Procedures

Change

refresh_emission_view_hiunitstack
refresh_emission_view_lme
refresh_emission_view_noxappemixedfuel
refresh_emission_view_noxappesinglefuel

refresh_emission_view_noxmasscems
refresh_emission_view_so2appd
refresh_emission_view_so2cems

jwhitehead77

see changes needed in comments

jwhitehead77 · 2023-11-07T17:46:12Z

camdecmps/procedures/refresh_emission_view_noxmasscems.sql

+		mhv.FLOW_CALC_ADJUSTED_HRLY_VALUE AS ADJ_FLOW_USED,
+		mhv.FLOW_MODC_CD AS FLOW_MODC,
+		mhv.FLOW_PCT_AVAILABLE AS FLOW_PMA,
+		dhv.CALC_PCT_MOISTURE AS PCT_H2O_USED, 


NOTE #1: All the DHV. aliases will need to be dhv.NOX_ since the original DHV alias joined on the NOX parameter...

INNER JOIN camdecmps.DERIVED_HRLY_VALUE DHV ON DHV.HOUR_ID = HOD.HOUR_ID AND DHV.PARAMETER_CD = 'NOX'

jwhitehead77 · 2023-11-07T17:49:36Z

camdecmps/procedures/refresh_emission_view_noxmasscems.sql

+		dhv.CALC_PCT_MOISTURE AS PCT_H2O_USED, 
 		CASE 
-			WHEN (DHV.CALC_PCT_MOISTURE IS NOT NULL) THEN 
+			WHEN (dhv.CALC_PCT_MOISTURE IS NOT NULL) THEN 


see note #1

jwhitehead77 · 2023-11-07T17:54:31Z

camdecmps/procedures/refresh_emission_view_noxmasscems.sql

+	  AND mhv.MON_LOC_ID = hod.MON_LOC_ID
+	  AND mhv.RPT_PERIOD_ID = hod.RPT_PERIOD_ID
+	INNER JOIN camdecmps.MONITOR_FORMULA  mf_HI 
+		ON mf_HI.MON_FORM_ID = dhv.MON_FORM_ID AND mf_HI.EQUATION_CD LIKE 'F-26%'


the original code used the DHV alias which was the NOX parameter vs the HI parameter

INNER JOIN camdecmps.MONITOR_FORMULA MF ON DHV.MON_FORM_ID = MF.MON_FORM_ID AND MF.EQUATION_CD LIKE 'F-26%'

jwhitehead77 · 2023-11-07T17:57:17Z

camdecmps/procedures/refresh_emission_view_noxmasscems.sql

-		ON DHV.HOUR_ID = H2O_MHV.HOUR_ID AND H2O_MHV.PARAMETER_CD = 'H2O' 
-	LEFT OUTER JOIN camdecmps.DERIVED_HRLY_VALUE  H2O_DHV 
-		ON DHV.HOUR_ID = H2O_DHV.HOUR_ID AND H2O_DHV.PARAMETER_CD = 'H2O' 
+		mf.EQUATION_CD AS NOX_MASS_FORMULA_CD,


The mf alias is undefined as you have mf_HI alias below which is using the HI parameter vs the NOX parameter

INNER JOIN camdecmps.MONITOR_FORMULA mf_HI ON mf_HI.MON_FORM_ID = dhv.MON_FORM_ID AND mf_HI.EQUATION_CD LIKE 'F-26%'

jwhitehead77 · 2023-11-07T17:57:42Z

camdecmps/procedures/refresh_emission_view_noxmasscems.sql

-	LEFT OUTER JOIN camdecmps.DERIVED_HRLY_VALUE  H2O_DHV 
-		ON DHV.HOUR_ID = H2O_DHV.HOUR_ID AND H2O_DHV.PARAMETER_CD = 'H2O' 
+		mf.EQUATION_CD AS NOX_MASS_FORMULA_CD,
+		dhv.ADJUSTED_HRLY_VALUE AS RPT_NOX_MASS,


see note #1

jwhitehead77 · 2023-11-07T17:57:47Z

camdecmps/procedures/refresh_emission_view_noxmasscems.sql

-		ON DHV.HOUR_ID = H2O_DHV.HOUR_ID AND H2O_DHV.PARAMETER_CD = 'H2O' 
+		mf.EQUATION_CD AS NOX_MASS_FORMULA_CD,
+		dhv.ADJUSTED_HRLY_VALUE AS RPT_NOX_MASS,
+		dhv.CALC_ADJUSTED_HRLY_VALUE AS CALC_NOX_MASS,


see note #1

…ipts into feature/5793_Refactor_Refresh_EV_DB

djw4erg

Please note the file comments and individual comments. In some cases the select statements for the inserts will not actually run, Mostly because of alias and column name issues, but in some cases because of columns not included in the pivotes.

djw4erg · 2023-11-30T15:55:51Z

camdecmps/procedures/refresh_emission_view_hiunitstack.sql

This script only joined to DERIVED_HRLY_VALUE once (HI) and MONITOR_HRLY_VALUE once (FLOW). The benefit of the pivot method is that it allows the multiple join on either table to become a single join. But since only one join is involved, this change would complicate the code with no benefit.

I believe that this change should be reverted.

djw4erg · 2023-11-30T16:04:24Z

camdecmps/procedures/refresh_emission_view_lme.sql

+		hod.HR_LOAD as UNIT_LOAD,
+		hod.LOAD_UOM_CD as LOAD_UOM,
+		hod.HOUR_ID,
+		dhv_HIT.MODC_CD as HI_MODC,


For any column with a "dhv_hit" alias the alias should be "dhv" and the "HIT_" should prefix the column name.

dhv_HIT.MODC_CD as HI_MODC, dhv_HIT.ADJUSTED_HRLY_VALUE AS RPT_HEAT_INPUT, dhv_HIT.CALC_ADJUSTED_HRLY_VALUE AS CALC_HEAT_INPUT,

djw4erg · 2023-11-30T16:11:39Z

camdecmps/procedures/refresh_emission_view_lme.sql

+		dhv_HIT.MODC_CD as HI_MODC,
+		dhv_HIT.ADJUSTED_HRLY_VALUE AS RPT_HEAT_INPUT,
+		dhv_HIT.CALC_ADJUSTED_HRLY_VALUE AS CALC_HEAT_INPUT,
+		dhv_SO2M.FUEL_CD as SO2M_FUEL_TYPE,


For any column with a "dhv_so2m" alias the alias should be "dhv" and the "SO2M__" should prefix the column name.

dhv_SO2M.FUEL_CD as SO2M_FUEL_TYPE, dhv_SO2M.ADJUSTED_HRLY_VALUE AS RPT_SO2_MASS, dhv_SO2M.CALC_ADJUSTED_HRLY_VALUE AS CALC_SO2_MASS,

djw4erg · 2023-11-30T16:47:07Z

camdecmps/procedures/refresh_emission_view_lme.sql

+		md_SO2R.DEFAULT_VALUE as SO2_EMISS_RATE,
+		dhv_SO2M.ADJUSTED_HRLY_VALUE AS RPT_SO2_MASS,
+		dhv_SO2M.CALC_ADJUSTED_HRLY_VALUE AS CALC_SO2_MASS,
+		dhv_NOXM.FUEL_CD as NOXM_FUEL_TYPE,


For any column with a "dhv_noxm" alias the alias should be "dhv" and the "NOXM__" should prefix the column name.

dhv_NOXM.OPERATING_CONDITION_CD, dhv_NOXM.ADJUSTED_HRLY_VALUE as RPT_NOX_MASS, dhv_NOXM.CALC_ADJUSTED_HRLY_VALUE as CALC_NOX_MASS,

djw4erg · 2023-11-30T16:48:47Z

camdecmps/procedures/refresh_emission_view_lme.sql

 		END as NOX_EMISS_RATE,
-		NOXM_DHV.ADJUSTED_HRLY_VALUE as RPT_NOX_MASS,
-		NOXM_DHV.CALC_ADJUSTED_HRLY_VALUE as CALC_NOX_MASS,
-		CO2M_DHV.FUEL_CD as CO2M_FUEL_TYPE,


For any column with a "dhv_co2m" alias the alias should be "dhv" and the "CO2M__" should prefix the column name.

dhv_CO2M.FUEL_CD as CO2M_FUEL_TYPE, dhv_CO2M.ADJUSTED_HRLY_VALUE as RPT_CO2_MASS, dhv_CO2M.CALC_ADJUSTED_HRLY_VALUE as CALC_CO2_MASS,

djw4erg · 2023-11-30T19:36:02Z

camdecmps/procedures/refresh_emission_view_noxappemixedfuel.sql

+	  AND dhv.MON_LOC_ID = hod.MON_LOC_ID
+	  AND dhv.RPT_PERIOD_ID = hod.RPT_PERIOD_ID
+	JOIN camdecmps.MONITOR_SYSTEM ms_NOXR  
+		ON dhv_NOXR.MON_SYS_ID = ms_NOXR.MON_SYS_ID AND ms_NOXR.SYS_TYPE_CD='NOXE'


First, note the general comment on this file, which affects this line.

Additionally, the MON_SYS_ID column was not included as a column in the camdecmps.get_derived_hourly_values_pivoted function. So that function will need to be updated to include MON_SYS_ID.

djw4erg · 2023-11-30T19:58:34Z

camdecmps/procedures/refresh_emission_view_noxappesinglefuel.sql

+	LEFT JOIN camdecmps.MONITOR_SYSTEM ms 
+		ON hff.MON_SYS_ID = ms.MON_SYS_ID
+	LEFT JOIN camdecmps.MONITOR_SYSTEM ms_NOXR 
+		ON hpff_NOXR.MON_SYS_ID = ms_NOXR.MON_SYS_ID


First, note the general comment on this file, which affects this line.

Additionally, the MON_SYS_ID column was not included as a column in the camdecmps.get_hourly_param_fuel_flow_pivotedfunction. So that function will need to be updated to include MON_SYS_ID.

djw4erg · 2023-12-01T16:27:33Z

camdecmps/procedures/refresh_emission_view_so2appd.sql

This script only joined to DERIVED_HRLY_VALUE once (SO2). The benefit of the pivot method is that it allows the multiple joins on a table to become a single join. But since only one join is involved, this change would complicate the code with no benefit.

I believe that this change for DERIVED_HRLY_VALUE should be reverted despite any additional comments about DHV.

djw4erg · 2023-12-01T16:30:21Z

camdecmps/procedures/refresh_emission_view_so2appd.sql

+	LEFT OUTER JOIN camdecmps.MONITOR_FORMULA AS mf 
+		ON hpff_SO2.MON_FORM_ID = mf.MON_FORM_ID
+	LEFT OUTER JOIN camdecmps.MONITOR_FORMULA AS mf_SUMMATION 
+		ON dhv_SO2.MON_FORM_ID = mf_SUMMATION.MON_FORM_ID


The "dhv_SO2.MON_FORM_ID" reference should be "dhv.SO2_MON_FORM_ID".

djw4erg · 2023-12-01T16:43:03Z

camdecmps/procedures/refresh_emission_view_so2appd.sql

+	LEFT OUTER JOIN camdecmps.MONITOR_SYSTEM ms 
+		ON hff.MON_SYS_ID = ms.MON_SYS_ID
+	LEFT OUTER JOIN camdecmps.MONITOR_FORMULA AS mf 
+		ON hpff_SO2.MON_FORM_ID = mf.MON_FORM_ID


The "hpff_SO2.MON_FORM_ID" reference should be "hpff.SO2_MON_FORM_ID".

feature/refresh_emission_view_noxmasscems

4661eda

ergjustin requested a review from jwhitehead77 November 1, 2023 03:19

jwhitehead77 suggested changes Nov 7, 2023

View reviewed changes

fix:requested changes

4bc250b

ergjustin requested a review from jwhitehead77 November 16, 2023 19:09

ergjustin added 3 commits November 20, 2023 08:46

feature/update refresh_emission_view

ec5f367

Merge branch 'develop' of https://github.com/US-EPA-CAMD/easey-db-scr…

49b2d10

…ipts into feature/5793_Refactor_Refresh_EV_DB

feature/update refresh_emission_view_hiunitstack

9fa07fb

ergjustin removed the request for review from jwhitehead77 November 20, 2023 16:11

ergjustin mentioned this pull request Nov 21, 2023

Refactor Refresh Emissions Views Database Procedures US-EPA-CAMD/easey-ui#5793

Open

25 tasks

ergjustin added 3 commits November 21, 2023 18:25

feature/refresh_emission_view_noxappemixedfuel

39d5312

feature/refresh_emission_view_noxappesinglefuel

56d10c7

feature/refresh_emission_view_lme

a6ac242

ergjustin requested a review from djw4erg November 27, 2023 14:53

djw4erg requested changes Dec 1, 2023

View reviewed changes

annalbrecht added the DPC/ERG label Feb 12, 2024

maheese assigned shahbazkhan1999 Feb 14, 2024

djw4erg assigned renaemyers and unassigned shahbazkhan1999 Feb 29, 2024

mark-hayward-erg added Phase 1 and removed DPC/ERG labels Mar 8, 2024

mark-hayward-erg linked an issue Mar 8, 2024 that may be closed by this pull request

Refactor Refresh Emissions Views Database Procedures US-EPA-CAMD/easey-ui#5793

Open

25 tasks

mark-hayward-erg removed the Phase 1 label Mar 8, 2024

annalbrecht added the Phase 1 label Apr 9, 2024

feature/refresh_emission_view_noxmasscems #10

Are you sure you want to change the base?

feature/refresh_emission_view_noxmasscems #10

Uh oh!

Conversation

ergjustin commented Nov 1, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Ticket

Change

Uh oh!

jwhitehead77 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

djw4erg left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

ergjustin commented Nov 1, 2023 •

edited

Loading