Add qty fields to market orders #283
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icendoan
commented
Apr 23, 2025
cogs/commands/market.py
Outdated
| def bid(self, price, user_id): | ||
| self.bids.append(Order(price, 'bid', user_id)) | ||
| def bid(self, price, user_id, qty): | ||
| self.bids.append(Order(price, 'bid', user_id, qty)) | ||
| heapq.heapify(self.bids) |
There was a problem hiding this comment.
Should probably also consider heapq.heappush for this, as it can't be slower than calling heapify every time
icendoan
force-pushed
the
master
branch
2 times, most recently
from
f395109 to
a47230e
Compare
icendoan
force-pushed
the
master
branch
4 times, most recently
from
4afd282 to
308f08c
Compare
jfitz02
reviewed
Apr 30, 2025
cogs/commands/market.py
Outdated
|
|
||
| await ctx.reply("Bid placed", ephemeral=True) | ||
|
|
||
| if did_trade is not None: | ||
| await ctx.reply(did_trade, ephemeral=False) | ||
|
|
||
| @commands.hybrid_command(help=LONG_HELP_TEXT, brief=SHORT_HELP_TEXT) | ||
| async def ask_market(self, ctx: Context, price: float, *, market: clean_content): | ||
| async def ask_market(self, ctx: Context, price: float, qty: int, *, market: clean_content): | ||
| """You would place a bid by using this command |
There was a problem hiding this comment.
Suggested change
| """You would place a bid by using this command | |
| """You would place an ask by using this command |
jfitz02
requested changes
Apr 30, 2025
cogs/commands/market.py
Outdated
| def bid(self, price, user_id): | ||
| self.bids.append(Order(price, 'bid', user_id)) | ||
| heapq.heapify(self.bids) | ||
| def bid(self, price, user_id, qty, time=time.time()): |
There was a problem hiding this comment.
pretty sure python will take time.time when it "creates" the function. So every bid will have the same time, and every ask will have the same time
| assert len(m.asks) == 0 | ||
| assert len(m.bids) == 1 | ||
| assert m.bids[0].qty == 99 | ||
| assert m.bids[0].order_time == 2 |
There was a problem hiding this comment.
Suggested change
| assert m.bids[0].order_time == 2 | |
| assert m.bids[0].order_time == 2 | |
| def test_time(): | |
| m = Market("test") | |
| assert m.ask(102, 1, 1) is None | |
| assert m.ask(102, 2, 1) is None | |
| ask_times = [ask.order_time for ask in m.asks] | |
| # Testing that all ask times are distinct | |
| assert all([ask_times.count(ask.order_time) == 1 for ask in m.asks]) | |
| assert m.bid(102, 3, 1) == """<@3> bought 1 from <@1> at 102""" |
There was a problem hiding this comment.
I wrote this in GitHub and have not tested it, but this is just the gist of testing times are ok
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The command should now be
/bid_market 123.4 1000 AAPLetc