Make save function of Alert/EventQueue and AlertHistory atomic #2594
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These save methods will save up to multiple objects to two separate models in one operation and we need to ensure that these related models are stored in the same transaction Without it this transaction the event notification sent by postgreSQL will be send before the related varmap model is saved
Codecov Report
@@ Coverage Diff @@
## 5.6.x #2594 +/- ##
==========================================
+ Coverage 53.72% 53.76% +0.03%
==========================================
Files 558 558
Lines 40587 40590 +3
==========================================
+ Hits 21806 21822 +16
+ Misses 18781 18768 -13
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After merging #2413 and everything related to it (#2515, #2545, #2560, #2565, #2580) it happened occasionally that notifications were sent out with the error
We could pinpoint that this happened due to the eventengine being notified about a new event in the EventQueue and processing it without the varmap being saved yet, which lead to this error, since the alert type is saved in the varmap.
Making the save function atomic prevents this from happening since the eventengine only starts processing the event when all information is saved properly.