Skip to content

Conversation

johannaengland
Copy link
Contributor

Scope and purpose

Fixes #3383.

Screenshot:
IMG_20250929_085120

Contributor Checklist

Every pull request should have this checklist filled out, no matter how small it is.
More information about contributing to NAV can be found in the
Hacker's guide to NAV.

  • Added a changelog fragment for towncrier
  • Added/amended tests for new/changed code
  • Added/changed documentation
  • Linted/formatted the code with ruff, easiest by using pre-commit
  • Wrote the commit message so that the first line continues the sentence "If applied, this commit will ...", starts with a capital letter, does not end with punctuation and is 50 characters or less long. See https://cbea.ms/git-commit/
  • Based this pull request on the correct upstream branch: For a patch/bugfix affecting the latest stable version, it should be based on that version's branch (<major>.<minor>.x). For a new feature or other additions, it should be based on master.
  • If applicable: Created new issues if this PR does not fix the issue completely/there is further work to be done
  • If it's not obvious from a linked issue, described how to interact with NAV in order for a reviewer to observe the effects of this change first-hand (commands, URLs, UI interactions)
  • If this results in changes in the UI: Added screenshots of the before and after
  • If this adds a new Python source code file: Added the boilerplate header to that file

And improve the read-write profile exception message
@johannaengland johannaengland requested a review from a team September 29, 2025 06:52
@johannaengland johannaengland self-assigned this Sep 29, 2025
Copy link

codecov bot commented Sep 29, 2025

Codecov Report

❌ Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 61.44%. Comparing base (d29eb91) to head (778da28).

Files with missing lines Patch % Lines
python/nav/arnold.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           5.14.x    #3565      +/-   ##
==========================================
+ Coverage   61.29%   61.44%   +0.14%     
==========================================
  Files         610      610              
  Lines       44726    44726              
  Branches       43       43              
==========================================
+ Hits        27414    27480      +66     
+ Misses      17302    17236      -66     
  Partials       10       10              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@johannaengland johannaengland force-pushed the bugfix/arnold-no-read-write-profile branch from b0b3447 to 778da28 Compare September 29, 2025 08:04
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant