Add IL offset and method token to stack frame details. #2130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @joncham let me test it tomorrow. I'll get back to you! |
MindWrapper
approved these changes
Jul 7, 2025
joncham
commented
Jul 28, 2025
| @@ -48,8 +48,8 @@ struct _GHashTable { | |||
| Slot **table; | |||
| int table_size; | |||
| int in_use; | |||
| int threshold; | |||
There was a problem hiding this comment.
This was only used in one place, but never updated.
joncham
commented
Jul 28, 2025
| int last_rehash; | ||
| gboolean uses_default_hash_and_equality; |
There was a problem hiding this comment.
This allows us to perform the same hashing/equality operations when out of process.
joncham
commented
Jul 28, 2025
| @@ -239,8 +240,7 @@ g_hash_table_insert_replace (GHashTable *hash, gpointer key, gpointer value, gbo | |||
| sanity_check (hash); | |||
|
|
|||
| equal = hash->key_equal_func; | |||
| if (hash->in_use >= hash->threshold) | |||
There was a problem hiding this comment.
The rehash was always occurring, as threshold was always 0.
UnityAlex
reviewed
Jul 29, 2025
scott-ferguson-unity
approved these changes
Jul 29, 2025
UnityAlex
reviewed
Jul 29, 2025
Comment on lines
+404
to
+405
| result |= (byte & 0x7f) << shift; | ||
| if ((byte & 0x80) == 0) |
There was a problem hiding this comment.
I see in mono-debug that these hardcoded values are used there as well but I'm still curious what they are?
There was a problem hiding this comment.
I believe this is variable length encoding of integer values. Thus small values could be contained within a single byte. Larger values two bytes, etc.
UnityAlex
approved these changes
Jul 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support to read IL offset and method token out-of-process (oop). This will enable the symbolication of managed frames to file/line level rather than just the method level.
Notes:
int _GHashTable::thresholdfield. This was never updated, always had value0, and thus always caused a rehash when checked.gboolean _GHashTable::uses_default_hash_and_equalityfield. The out-of-process read logic needs to inspect a hash table, and thus can only be done when direct hash/equality is used; custom hash/equality functions are not supported.g_hash_table_lookup_oopto perform the actual hash lookup. This was done inmono/eglib/ghashtable.cdirectly to avoid having to expose hashtable implementation internals.mono/metadata/oop.creplicate enough data/logic for a simple oop version ofmono_debug_read_methodthat can retrieve the offset/token info.These changes have some risk, but they are only invoked when processing a crash. Thus, we may lose some crash info in the case of errors, but we should not cause any additional crashes.
Reviewers: please consider these questions as well! ❤️