Remove feature flag: registerFrontendClient #10024
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
@sastromskis, core features have been modified in this pull request. Please review carefully! |
github-actions
bot
requested review from
chriswk,
FredrikOseberg,
gastonfournier and
ivarconr
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature Flag Removal: registerFrontendClient
This PR removes the
registerFrontendClientfeature flag from the codebase. The changes have been automatically applied using Henry, our automated flag removal assistant.Flag Value:
keptThis change removes the registerFrontendClient feature flag from the codebase.
The feature controlled by this flag has been kept, meaning its functionality is
now permanently enabled.
What was removed:
• The registerFrontendClient flag definition in src/lib/types/experimental.ts.
• The registerFrontendClient flag from the UiFlags interface in
frontend/src/interfaces/uiConfig.ts.
• The flag from experimental flag configurations in src/server-dev.ts and
src/test/e2e/api/admin/applications.e2e.test.ts.
• Conditional checks for this.flagResolver.isEnabled('registerFrontendClient')
in:
• src/lib/features/frontend-api/frontend-api-service.ts
• src/lib/features/metrics/instance/metrics.ts
• The useUiFlag('registerFrontendClient') hook call and associated conditional
rendering logic in frontend/src/component/application/ApplicationChart.tsx.
What was kept:
• The core functionality of registering frontend clients.
• In src/lib/features/frontend-api/frontend-api-service.ts, the logic to
register frontend clients via
this.services.clientInstanceService.registerFrontendClient(client) will
now always execute if metrics.instanceId and sdkVersion are present.
• In src/lib/features/metrics/instance/metrics.ts, the logic to register
frontend clients via
this.clientInstanceService.registerFrontendClient(...) during bulk metrics
processing will now always execute for applications with sdkType ===
'frontend' and a valid sdkVersion.
• In frontend/src/component/application/ApplicationChart.tsx, the UI will now
consistently display separate "Backend SDK" and "Frontend SDK" sections if
data for them exists, instead of a generic "SDK" section.
Why these changes were made:
The registerFrontendClient feature flag was deemed stable and ready for
permanent activation. Removing the flag simplifies the codebase by eliminating
conditional logic and makes the frontend client registration behavior standard.
Tokens: 46k sent, 2.0k received. Cost: $0.08 message, $0.08 session.
Applied edit to frontend/src/interfaces/uiConfig.ts
Applied edit to src/server-dev.ts
Applied edit to src/test/e2e/api/admin/applications.e2e.test.ts
Applied edit to src/lib/types/experimental.ts
Applied edit to frontend/src/component/application/ApplicationChart.tsx
Applied edit to src/lib/features/frontend-api/frontend-api-service.ts
Applied edit to src/lib/features/metrics/instance/metrics.ts
Commit e20ff3c chore: remove registerFrontendClient flag, keep feature