Skip to content

Feat/twitter client #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Feat/twitter client #18

wants to merge 7 commits into from

Conversation

stevensf1998
Copy link
Contributor

No description provided.

@@ -1,4 +1,11 @@
WHITELISTED_WALLET_PRIVATE_KEY=<whitelisted-wallet-private-key>
BUYER_WALLET_PRIVATE_KEY=<buyer-wallet-private-key>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can keep the current envs? we can just use the same whitelisted dev key for all agents

@@ -1,3 +1,7 @@
WHITELISTED_WALLET_PRIVATE_KEY=<whitelisted-wallet-private-key>
BUYER_WALLET_PRIVATE_KEY=<buyer-wallet-private-key>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can keep the current one? we just use the same whitelisted dev key

@@ -32,10 +32,11 @@ def on_new_task(job: ACPJob):

# Initialize the ACP client
acp_client = VirtualsACP(
wallet_private_key=env.WHITELISTED_WALLET_PRIVATE_KEY,
wallet_private_key=env.SELLER_WALLET_PRIVATE_KEY,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't think this is needed

if memo.next_phase == ACPJobPhase.COMPLETED:
print("Evaluating deliverable", job.id)
job.evaluate(True)
break

# Initialize the ACP client
acp_client = VirtualsACP(
wallet_private_key=env.WHITELISTED_WALLET_PRIVATE_KEY,
wallet_private_key=env.EVALUATOR_WALLET_PRIVATE_KEY,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't think this is needed

acp = VirtualsACP(
wallet_private_key=env.WHITELISTED_WALLET_PRIVATE_KEY,
wallet_private_key=env.BUYER_WALLET_PRIVATE_KEY,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't think this is needed

return memo.content if memo else None

@property
def deliverable(self) -> Optional[str]:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perhaps better to rename as get_deliverable(self)?

return memo.content if memo else None

@property
def provider_agent(self) -> Optional["IACPAgent"]:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perhaps better to rename as get_provider_agent(self)?

return self.acp_client.get_agent(self.provider_address)

@property
def client_agent(self) -> Optional["IACPAgent"]:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perhaps better to rename as get_client_agent(self)?

return self.acp_client.get_agent(self.client_address)

@property
def evaluator_agent(self) -> Optional["IACPAgent"]:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perhaps better to rename as get_evaluator_agent(self)?

@property
def evaluator_agent(self) -> Optional["IACPAgent"]:
"""Get the evaluator agent details"""
return self.acp_client.get_agent(self.client_address)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't it be "evaluator_address"?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants