Skip to content

Fix plugin unloading for servers using papers modern plugin manager #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix plugin unloading for servers using papers modern plugin manager #9

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 49 additions & 2 deletions src/main/java/com/volmit/bile/BileUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
import java.io.IOException;
import java.io.InputStream;
import java.lang.reflect.Field;
import java.lang.reflect.Method;
import java.net.URLClassLoader;
import java.nio.ByteBuffer;
import java.security.MessageDigest;
Expand All @@ -23,6 +24,39 @@
import java.util.zip.ZipFile;

public class BileUtils {
public static boolean isModernPaperPlugin = false;
private static Method INSTANCE_METHOD;
private static Field INSTANCE_MANAGER_FIELD;
private static Field LOOKUP_NAMES_FIELD;
private static Method DISABLE_PLUGIN_METHOD;
private static Field PLUGIN_LIST_FIELD;

static {
try {
final Class<?> PAPER_PLUGIN_MANAGER = Class.forName("io.papermc.paper.plugin.manager.PaperPluginManagerImpl");

INSTANCE_METHOD = PAPER_PLUGIN_MANAGER.getMethod("getInstance");
final Object instance = INSTANCE_METHOD.invoke(null);

INSTANCE_MANAGER_FIELD = instance.getClass().getDeclaredField("instanceManager");
INSTANCE_MANAGER_FIELD.setAccessible(true);

final Object instanceManager = INSTANCE_MANAGER_FIELD.get(instance);
LOOKUP_NAMES_FIELD = instanceManager.getClass().getDeclaredField("lookupNames");
LOOKUP_NAMES_FIELD.setAccessible(true);

DISABLE_PLUGIN_METHOD = instanceManager.getClass().getMethod("disablePlugin", Plugin.class);
DISABLE_PLUGIN_METHOD.setAccessible(true);

PLUGIN_LIST_FIELD = instanceManager.getClass().getDeclaredField("plugins");
PLUGIN_LIST_FIELD.setAccessible(true);

isModernPaperPlugin = true;
}
catch (Exception ignored) {}
}


public static void delete(Plugin p) throws IOException {
File f = getPluginFile(p);
backup(p);
Expand Down Expand Up @@ -141,6 +175,19 @@ public static Set<File> unload(Plugin plugin) {
boolean reloadlisteners = true;

if (pluginManager != null) {
if (isModernPaperPlugin) {
try {
final Object instanceManager = INSTANCE_MANAGER_FIELD.get(INSTANCE_METHOD.invoke(null));
DISABLE_PLUGIN_METHOD.invoke(instanceManager, plugin);

((Map<String, Object>) LOOKUP_NAMES_FIELD.get(instanceManager)).remove(plugin.getName().toLowerCase());
((List<Plugin>) PLUGIN_LIST_FIELD.get(instanceManager)).remove(plugin);
}
catch (Exception e) {
e.printStackTrace();
}
}

pluginManager.disablePlugin(plugin);

try {
Expand Down Expand Up @@ -169,9 +216,9 @@ public static Set<File> unload(Plugin plugin) {
e.printStackTrace();
return new HashSet<>();
}
}

pluginManager.disablePlugin(plugin);
pluginManager.disablePlugin(plugin);
}

if (plugins != null) {
plugins.remove(plugin);
Expand Down