Skip to content

fix AllowSynchronousIO of messagepack in core3.0 #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix AllowSynchronousIO of messagepack in core3.0 #186

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions src/WebApiContrib.Core.Formatter.MessagePack/MessagePackInputFormatter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,10 +43,13 @@ public override async Task<InputFormatterResult> ReadRequestBodyAsync(InputForma
request.Body.Seek(0L, SeekOrigin.Begin);
}

var result = MessagePackSerializer.NonGeneric.Deserialize(context.ModelType, request.Body, _options.FormatterResolver);
var formatterResult = await InputFormatterResult.SuccessAsync(result);

return formatterResult;
using (MemoryStream stream = new MemoryStream())
{
await request.Body.CopyToAsync(stream);
stream.Position = 0;
var result = MessagePackSerializer.NonGeneric.Deserialize(context.ModelType, stream, _options.FormatterResolver);
return await InputFormatterResult.SuccessAsync(result);
}
}

protected override bool CanReadType(Type type)
Expand Down
9 changes: 6 additions & 3 deletions src/WebApiContrib.Core.Formatter.MessagePack/MessagePackOutputFormatter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,15 +24,18 @@ public MessagePackOutputFormatter(MessagePackFormatterOptions messagePackFormatt
}
}

public override Task WriteResponseBodyAsync(OutputFormatterWriteContext context)
public override async Task WriteResponseBodyAsync(OutputFormatterWriteContext context)
{
if (context == null)
{
throw new ArgumentNullException(nameof(context));
}

MessagePackSerializer.NonGeneric.Serialize(context.ObjectType, context.HttpContext.Response.Body, context.Object, _options.FormatterResolver);
return Task.FromResult(0);
using (MemoryStream stream = new MemoryStream())
{
MessagePackSerializer.NonGeneric.Serialize(context.ObjectType, stream, context.Object, _options.FormatterResolver);
await context.HttpContext.Response.Body.WriteAsync(stream.ToArray(), 0, (int)stream.Length);
}
}
}
}