[custom-descriptors] Update struct.new parsing and validation #7643
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When allocating structs that have custom descriptors, struct.new and struct.new_default must take an additional operand for the descriptor.
kripken
reviewed
Jun 9, 2025
src/wasm.h
Outdated
|
|
||
| bool isWithDefault() { | ||
| return hasDescriptor() ? (operands.size() == 1) : operands.empty(); | ||
| } |
There was a problem hiding this comment.
The comment on line 1670 should be updated?
But, perhaps another option is to add a designated field for this?
Expression* descriptor = nullptr;
There was a problem hiding this comment.
Yes, adding an optional designated field probably makes sense.
There was a problem hiding this comment.
Following offline discussion I'll work towards that in this branch.
tlively
commented
Jun 10, 2025
src/wasm/wasm-ir-builder.cpp
Outdated
| curr.operands.resize(type.getStruct().fields.size()); | ||
| CHECK_ERR(visitStructNew(&curr)); | ||
| push(builder.makeStructNew(type, std::move(curr.operands))); | ||
| CHECK_ERR(ChildPopper{*this}.visitStructNew(&curr)); |
There was a problem hiding this comment.
Since the ChildPopper visitor doesn't take any additional arguments, this can remain simply visitStructNew here and below.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When allocating structs that have custom descriptors, struct.new and
struct.new_default must take an additional operand for the descriptor.