Skip to content

updated react to v 18 #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

updated react to v 18 #84

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e210f57
updated react to v 18
Binu42 Apr 16, 2022
f5c7457
concurrent rendering using createRoot
Binu42 Apr 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,13 +13,13 @@
"bulma": "^0.8.2",
"github-slugger": "^1.3.0",
"highlight.js": "^10.0.3",
"react": "^16.13.1",
"react-dom": "^16.13.1",
"react": "^18.0.0",
"react-dom": "^18.0.0",
"react-feather": "^2.0.8",
"react-github-btn": "^1.2.0",
"react-hotjar": "^2.2.1",
"react-markdown": "^4.3.1",
"react-router-dom": "^5.1.2",
"react-router-dom": "^6.3.0",
"react-scripts": "3.4.1",
"react-tooltip": "^4.2.6"
},
Expand Down
39 changes: 18 additions & 21 deletions src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,28 +1,25 @@
import React from 'react';
import ReactDOM from 'react-dom';
import './index.css';
import App from './App';
import 'bulma/css/bulma.min.css';
import { BrowserRouter as Router } from 'react-router-dom';
import ScrollToTop from './Components/ScrollToTop';
import * as serviceWorker from './serviceWorker';
import React from "react";
import { createRoot } from "react-dom/client";
import "./index.css";
import App from "./App";
import "bulma/css/bulma.min.css";
import { BrowserRouter as Router } from "react-router-dom";
import * as serviceWorker from "./serviceWorker";

ReactDOM.render(
<React.StrictMode>
<Router>
<ScrollToTop />
<App />
</Router>
</React.StrictMode>,
document.getElementById('root')
const rootElement = document.getElementById("root");
const root = createRoot(rootElement);
root.render(
<Router>
<App />
</Router>
);

serviceWorker.register({
onUpdate: registration => {
alert('New version is available!, please update?');
onUpdate: (registration) => {
alert("New version is available!, please update?");
if (registration && registration.waiting) {
registration.waiting.postMessage({ type: 'SKIP_WAITING' });
registration.waiting.postMessage({ type: "SKIP_WAITING" });
}
window.location.reload();
}
});
},
});
Loading