WIP support GET waiting for next update #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A very common case in our integration tests is that we trigger some action and want to assert for an outcome in Kafka. Typical roundrips are 100-2000 ms, and retrying in tests tends to get verbose.
The plan here is for
/cache/v1/raw/{key}to return thebyte[]value as before but with a response headerx-kkv-record-timestampcontaining kafka's timestamp for the last update of the cache entry.With that timestamp clients should then be able to invoke the same endpoint with request header
x-kkv-updated-afterand the same value. An async wait in the REST resource should wait for up to 20 (TBD, less than 30) seconds, then send (TBD) status if the update hasn't happened, or the record if the update has happened.