Skip to content

Miscellaneous cleanup #656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 28, 2025
Merged

Miscellaneous cleanup #656

merged 5 commits into from
Aug 28, 2025

Conversation

Grazfather
Copy link
Collaborator

@Grazfather Grazfather commented Aug 22, 2025 •
edited
Loading

  • Fix error checks in bus scan (Read returns illegal address, not reserved)
  • Rename get_register in the ICM-20948 driver to get_reg for consistency
  • Remove redundant comptime size check: The size is verified because the packed struct has a size

@Grazfather Grazfather marked this pull request as ready for review August 28, 2025 15:36
@Grazfather Grazfather merged commit e2a07cf into main Aug 28, 2025
48 of 50 checks passed
@Grazfather Grazfather deleted the cleanups branch August 28, 2025 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattnite mattnite mattnite approved these changes

@tact1m4n3 tact1m4n3 tact1m4n3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Grazfather @mattnite @tact1m4n3